Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2896463002: DDC fixes for SpeechRecognition (Closed)

Created:
3 years, 7 months ago by vsm
Modified:
3 years, 7 months ago
Reviewers:
Alan Knight
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/runtime.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/lib_strong/html/speechrecognition_test.dart View 1 chunk +7 lines, -6 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
vsm
https://codereview.chromium.org/2896463002/diff/1/tests/lib_strong/html/speechrecognition_test.dart File tests/lib_strong/html/speechrecognition_test.dart (left): https://codereview.chromium.org/2896463002/diff/1/tests/lib_strong/html/speechrecognition_test.dart#oldcode35 tests/lib_strong/html/speechrecognition_test.dart:35: var e = new Event.eventType('SpeechRecognitionError', 'speech'); This and commented ...
3 years, 7 months ago (2017-05-18 20:11:52 UTC) #1
vsm
3 years, 7 months ago (2017-05-18 20:12:35 UTC) #3
Alan Knight
lgtm
3 years, 7 months ago (2017-05-18 20:17:33 UTC) #4
vsm
3 years, 7 months ago (2017-05-19 00:06:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b82b0e29ed3af09fd5a93d78d6188bf76db5579c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698