extensions/common/api/PRESUBMIT.py - Issue 2896433002: WebUI: Add externs from chrome.mimeHandlerPrivate API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/common/api/PRESUBMIT.py

Issue 2896433002: WebUI: Add externs from chrome.mimeHandlerPrivate API. (Closed)

Patch Set: Nit Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/closure_compiler/externs/compiled_resources2.gyp » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Chromium presubmit script for src/extensions/common.	5 """Chromium presubmit script for src/extensions/common.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details on the presubmit API built into depot_tools.	8 for more details on the presubmit API built into depot_tools.

9 """	9 """

10	10

(...skipping 11 matching lines...) Expand all Loading...
22	22

23 join = input_api.os_path.join	23 join = input_api.os_path.join

24 api_root = input_api.PresubmitLocalPath()	24 api_root = input_api.PresubmitLocalPath()

25 externs_root = join(api_root, '..', '..', '..', 'third_party',	25 externs_root = join(api_root, '..', '..', '..', 'third_party',

26 'closure_compiler', 'externs')	26 'closure_compiler', 'externs')

27	27

28 api_pairs = {	28 api_pairs = {

29 join(api_root, 'bluetooth.idl'): join(externs_root, 'bluetooth.js'),	29 join(api_root, 'bluetooth.idl'): join(externs_root, 'bluetooth.js'),

30 join(api_root, 'metrics_private.json'):	30 join(api_root, 'metrics_private.json'):

31 join(externs_root, 'metrics_private.js'),	31 join(externs_root, 'metrics_private.js'),

	32 join(api_root, 'mime_handler_private.idl'):

	33 join(externs_root, 'mime_handler_private.js'),

32 # TODO(rdevlin.cronin): Add more!	34 # TODO(rdevlin.cronin): Add more!

33 }	35 }

34	36

35 return ExternsChecker(input_api, output_api, api_pairs).RunChecks()	37 return ExternsChecker(input_api, output_api, api_pairs).RunChecks()

36	38

37	39

38 def CheckChangeOnUpload(input_api, output_api):	40 def CheckChangeOnUpload(input_api, output_api):

39 return _CheckExterns(input_api, output_api)	41 return _CheckExterns(input_api, output_api)

OLD	NEW