Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 2896423002: Make LibraryIndex lazy. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make LibraryIndex lazy. With this change it takes about 0.03% to create CoreTypes. R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/625129ac01189e39d7e4b6b9a7f4085861d1e9be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -27 lines) Patch
M pkg/kernel/lib/library_index.dart View 6 chunks +39 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 7 months ago (2017-05-23 19:51:29 UTC) #1
Paul Berry
lgtm. Probably should wait for the go-ahead from Peter or Kevin before landing.
3 years, 7 months ago (2017-05-23 20:16:13 UTC) #2
ahe
lgtm
3 years, 7 months ago (2017-05-23 20:39:43 UTC) #3
scheglov
3 years, 7 months ago (2017-05-23 21:28:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
625129ac01189e39d7e4b6b9a7f4085861d1e9be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698