Chromium Code Reviews| Index: pkg/compiler/lib/src/resolution/members.dart |
| diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart |
| index 307240b98966eaf09b7f6e80dda841c46b0976aa..9d5ae79146203cb26645ac559e2d4cb75215c47e 100644 |
| --- a/pkg/compiler/lib/src/resolution/members.dart |
| +++ b/pkg/compiler/lib/src/resolution/members.dart |
| @@ -3851,6 +3851,14 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> { |
| argumentsResult = |
| inConstantContext(() => resolveArguments(node.send.argumentsNode)); |
| } else { |
| + if (!node.isConst && constructor.isFromEnvironmentConstructor) { |
| + // TODO(sigmund): consider turning this into a compile-time-error. |
|
Emily Fortuna
2017/05/26 18:04:02
why isn't this a compile time error?
|
| + reporter.reportWarningMessage( |
| + node, |
| + MessageKind.FROM_ENVIRONMENT_MUST_BE_CONST, |
| + {'className': constructor.enclosingClass.name}); |
| + registry.registerFeature(Feature.THROW_UNSUPPORTED_ERROR); |
| + } |
| argumentsResult = resolveArguments(node.send.argumentsNode); |
| } |
| // TODO(johnniwinther): Avoid the need for a [Selector]. |