Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: pkg/compiler/lib/src/universe/feature.dart

Issue 2896393003: Remove factory body in *.fromEnvironment, and implement this same behavior (Closed)
Patch Set: turn warning into a hint Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/kernel_impact.dart ('k') | sdk/lib/_internal/js_runtime/lib/core_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/universe/feature.dart
diff --git a/pkg/compiler/lib/src/universe/feature.dart b/pkg/compiler/lib/src/universe/feature.dart
index 03315f070cba1c5960bd93de5925f982ce70de0d..d9799bca13e015aa4513f257fa48d4a1ecbb35fe 100644
--- a/pkg/compiler/lib/src/universe/feature.dart
+++ b/pkg/compiler/lib/src/universe/feature.dart
@@ -78,9 +78,13 @@ enum Feature {
/// static method.
THROW_NO_SUCH_METHOD,
- /// An implicit throw of a runtime error, like
+ /// An implicit throw of a runtime error, like in a runtime type check.
THROW_RUNTIME_ERROR,
+ /// An implicit throw of a `UnsupportedError`, like calling `new
+ /// bool.fromEnvironment`.
+ THROW_UNSUPPORTED_ERROR,
+
/// The need for a type variable bound check, like instantiation of a generic
/// type whose type variable have non-trivial bounds.
TYPE_VARIABLE_BOUNDS_CHECK,
« no previous file with comments | « pkg/compiler/lib/src/ssa/kernel_impact.dart ('k') | sdk/lib/_internal/js_runtime/lib/core_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698