pkg/compiler/lib/src/js_backend/mirrors_analysis.dart - Issue 2896393003: Remove factory body in *.fromEnvironment, and implement this same behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/mirrors_analysis.dart

Issue 2896393003: Remove factory body in *.fromEnvironment, and implement this same behavior (Closed)

Patch Set: turn warning into a hint Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/mirrors_analysis.dart

diff --git a/pkg/compiler/lib/src/js_backend/mirrors_analysis.dart b/pkg/compiler/lib/src/js_backend/mirrors_analysis.dart

index ca7bb5d4701523dabcd902c20919b8380dc7fb78..b3617d8c57d5e4069ec09f5a08ae590c4b0bc210 100644

--- a/pkg/compiler/lib/src/js_backend/mirrors_analysis.dart

+++ b/pkg/compiler/lib/src/js_backend/mirrors_analysis.dart

@@ -310,6 +310,7 @@ class MirrorsHandler {

assert(constructor.isDeclaration);

if (_shouldIncludeElementDueToMirrors(constructor,

includedEnclosing: enclosingWasIncluded)) {

+ if (constructor.isFromEnvironmentConstructor) return;

_logEnqueueReflectiveAction(constructor);

ClassElement cls = constructor.enclosingClass;

impactBuilder