Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: tests/compiler/dart2js_extra/new_from_env_test.dart

Issue 2896393003: Remove factory body in *.fromEnvironment, and implement this same behavior (Closed)
Patch Set: turn warning into a hint Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/compiler/dart2js_extra/dart2js_extra.status ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 import 'package:expect/expect.dart';
6
7 /// Dart2js only supports the const constructor for `?.fromEnvironment`. The
8 /// current behavior is to throw at runtime if they call this constructor with
9 /// `new` instead of `const`.
10 main() {
11 Expect.isFalse(const bool.fromEnvironment('X'));
12 Expect.isNull(const String.fromEnvironment('X'));
13 Expect.equals(const int.fromEnvironment('X', defaultValue: 0), 0);
14
15 Expect.throws(() => new bool.fromEnvironment('X'));
16 Expect.throws(() => new String.fromEnvironment('X'));
17 Expect.throws(() => new int.fromEnvironment('X', defaultValue: 0));
18 }
OLDNEW
« no previous file with comments | « tests/compiler/dart2js_extra/dart2js_extra.status ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698