Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: pkg/compiler/lib/src/js_backend/backend_impact.dart

Issue 2896393003: Remove factory body in *.fromEnvironment, and implement this same behavior (Closed)
Patch Set: turn warning into a hint Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.js_helpers.impact; 5 library dart2js.js_helpers.impact;
6 6
7 import '../common/names.dart'; 7 import '../common/names.dart';
8 import '../common_elements.dart' show CommonElements, ElementEnvironment; 8 import '../common_elements.dart' show CommonElements, ElementEnvironment;
9 import '../elements/types.dart' show InterfaceType; 9 import '../elements/types.dart' show InterfaceType;
10 import '../elements/entities.dart'; 10 import '../elements/entities.dart';
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 ] 296 ]
297 : [ 297 : [
298 _commonElements.throwRuntimeError, 298 _commonElements.throwRuntimeError,
299 ], 299 ],
300 otherImpacts: [ 300 otherImpacts: [
301 // Also register the types of the arguments passed to this method. 301 // Also register the types of the arguments passed to this method.
302 stringValues 302 stringValues
303 ]); 303 ]);
304 } 304 }
305 305
306 BackendImpact _throwUnsupportedError;
307
308 BackendImpact get throwUnsupportedError {
309 return _throwUnsupportedError ??= new BackendImpact(staticUses: [
310 _commonElements.throwUnsupportedError
311 ], otherImpacts: [
312 // Also register the types of the arguments passed to this method.
313 stringValues
314 ]);
315 }
316
306 BackendImpact _superNoSuchMethod; 317 BackendImpact _superNoSuchMethod;
307 318
308 BackendImpact get superNoSuchMethod { 319 BackendImpact get superNoSuchMethod {
309 return _superNoSuchMethod ??= new BackendImpact(staticUses: [ 320 return _superNoSuchMethod ??= new BackendImpact(staticUses: [
310 _commonElements.createInvocationMirror, 321 _commonElements.createInvocationMirror,
311 _commonElements.objectNoSuchMethod 322 _commonElements.objectNoSuchMethod
312 ], otherImpacts: [ 323 ], otherImpacts: [
313 _needsInt('Needed to encode the invocation kind of super.noSuchMethod.'), 324 _needsInt('Needed to encode the invocation kind of super.noSuchMethod.'),
314 _needsList('Needed to encode the arguments of super.noSuchMethod.'), 325 _needsList('Needed to encode the arguments of super.noSuchMethod.'),
315 _needsString('Needed to encode the name of super.noSuchMethod.') 326 _needsString('Needed to encode the name of super.noSuchMethod.')
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
792 /// Backend impact for type variables through mirrors. 803 /// Backend impact for type variables through mirrors.
793 BackendImpact get typeVariableMirror { 804 BackendImpact get typeVariableMirror {
794 return _typeVariableMirror ??= new BackendImpact(staticUses: [ 805 return _typeVariableMirror ??= new BackendImpact(staticUses: [
795 _commonElements.typeVariableConstructor, 806 _commonElements.typeVariableConstructor,
796 _commonElements.createRuntimeType 807 _commonElements.createRuntimeType
797 ], instantiatedClasses: [ 808 ], instantiatedClasses: [
798 _commonElements.typeVariableClass 809 _commonElements.typeVariableClass
799 ]); 810 ]);
800 } 811 }
801 } 812 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/elements/entities.dart ('k') | pkg/compiler/lib/src/js_backend/impact_transformer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698