Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: pkg/compiler/lib/src/common_elements.dart

Issue 2896393003: Remove factory body in *.fromEnvironment, and implement this same behavior (Closed)
Patch Set: turn warning into a hint Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/diagnostics/messages.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // TODO(sigmund): rename and move to common/elements.dart 5 // TODO(sigmund): rename and move to common/elements.dart
6 library dart2js.type_system; 6 library dart2js.type_system;
7 7
8 import 'common/names.dart' show Identifiers, Uris; 8 import 'common/names.dart' show Identifiers, Uris;
9 import 'constants/values.dart'; 9 import 'constants/values.dart';
10 import 'elements/entities.dart'; 10 import 'elements/entities.dart';
(...skipping 913 matching lines...) Expand 10 before | Expand all | Expand 10 after
924 924
925 FunctionEntity get throwIndexOutOfRangeException => 925 FunctionEntity get throwIndexOutOfRangeException =>
926 _findHelperFunction('ioore'); 926 _findHelperFunction('ioore');
927 927
928 FunctionEntity get exceptionUnwrapper => 928 FunctionEntity get exceptionUnwrapper =>
929 _findHelperFunction('unwrapException'); 929 _findHelperFunction('unwrapException');
930 930
931 FunctionEntity get throwRuntimeError => 931 FunctionEntity get throwRuntimeError =>
932 _findHelperFunction('throwRuntimeError'); 932 _findHelperFunction('throwRuntimeError');
933 933
934 FunctionEntity get throwUnsupportedError =>
935 _findHelperFunction('throwUnsupportedError');
936
934 FunctionEntity get throwTypeError => _findHelperFunction('throwTypeError'); 937 FunctionEntity get throwTypeError => _findHelperFunction('throwTypeError');
935 938
936 FunctionEntity get throwAbstractClassInstantiationError => 939 FunctionEntity get throwAbstractClassInstantiationError =>
937 _findHelperFunction('throwAbstractClassInstantiationError'); 940 _findHelperFunction('throwAbstractClassInstantiationError');
938 941
939 FunctionEntity _cachedCheckConcurrentModificationError; 942 FunctionEntity _cachedCheckConcurrentModificationError;
940 FunctionEntity get checkConcurrentModificationError => 943 FunctionEntity get checkConcurrentModificationError =>
941 _cachedCheckConcurrentModificationError ??= 944 _cachedCheckConcurrentModificationError ??=
942 _findHelperFunction('checkConcurrentModificationError'); 945 _findHelperFunction('checkConcurrentModificationError');
943 946
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
1266 // TODO(johnniwinther): Remove this when the resolver is removed. 1269 // TODO(johnniwinther): Remove this when the resolver is removed.
1267 DartType getUnaliasedType(DartType type); 1270 DartType getUnaliasedType(DartType type);
1268 1271
1269 /// Returns `true` if [member] a the synthetic getter `loadLibrary` injected 1272 /// Returns `true` if [member] a the synthetic getter `loadLibrary` injected
1270 /// on deferred libraries. 1273 /// on deferred libraries.
1271 bool isDeferredLoadLibraryGetter(MemberEntity member); 1274 bool isDeferredLoadLibraryGetter(MemberEntity member);
1272 1275
1273 /// Returns the metadata constants declared on [member]. 1276 /// Returns the metadata constants declared on [member].
1274 Iterable<ConstantValue> getMemberMetadata(MemberEntity member); 1277 Iterable<ConstantValue> getMemberMetadata(MemberEntity member);
1275 } 1278 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/diagnostics/messages.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698