Remove JS_CONST from CssStyleDeclaration, causes DDC problems

tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate

 
 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // WARNING: DO NOT EDIT THIS TEMPLATE FILE.
 // The template file was generated by scripts/css_code_generator.py
 
 // Source of CSS properties:
 //   CSSPropertyNames.in
@@ skipping 86 matching lines @@
   }
 $else
   static String _readCache(String key) => null;
   static void _writeCache(String key, value) {}
 $endif
 
   static String _camelCase(String hyphenated) {
 $if DART2JS
     var replacedMs = JS('String', r'#.replace(/^-ms-/, "ms-")', hyphenated);
 
-    var fToUpper = const JS_CONST(
+    var fToUpper = JS('',
         r'function(_, letter) { return letter.toUpperCase(); }');
     return JS('String', r'#.replace(/-([\da-z])/ig, #)', replacedMs, fToUpper);

[sra1, 2017/05/23 20:26:18]

You could inline it here.

return JS('String',
    r'#.replace(/-([\da-z])/ig, function(_, letter) { return
letter.toUpperCase())',
    replacedMs);

The whole reason for using JS_CONST was that originally, JS could not parse
functions. Now it can, so we don't need to name the function.

Up to you.

[Alan Knight, 2017/05/23 21:42:37]

Done.

 $else
     // The "ms" prefix is always lowercased.
     return hyphenated.replaceFirst(new RegExp('^-ms-'), 'ms-').replaceAllMapped(
         new RegExp('-([a-z]+)', caseSensitive: false),
         (match) => match[0][1].toUpperCase() + match[0].substring(2));
 $endif
   }
 
 $if DART2JS
   void _setPropertyHelper(String propertyName, String value, [String priority]) {
@@ skipping 4598 matching lines @@
 
   /** Gets the value of "zoom" */
   String get zoom =>
     getPropertyValue('zoom');
 
   /** Sets the value of "zoom" */
   set zoom(String value) {
     setProperty('zoom', value, '');
   }
 }