Remove JS_CONST from CssStyleDeclaration, causes DDC problems

Remove JS_CONST from CssStyleDeclaration, causes DDC problems

BUG=
R=sra@google.com, vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/e6c38ea30fa8c460b9d82038945c332ede51f79c

[Alan Knight, 2017-05-23 19:36:08]

alanknight@google.com changed reviewers:
+ vsm@google.com

[sra1, 2017-05-23 20:26:17]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-05-23 20:26:18]

lgtm

https://codereview.chromium.org/2896393002/diff/1/tools/dom/templates/html/im...
File tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate
(right):

https://codereview.chromium.org/2896393002/diff/1/tools/dom/templates/html/im...
tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate:109: return
JS('String', r'#.replace(/-([\da-z])/ig, #)', replacedMs, fToUpper);
You could inline it here.

return JS('String',
    r'#.replace(/-([\da-z])/ig, function(_, letter) { return
letter.toUpperCase())',
    replacedMs);

The whole reason for using JS_CONST was that originally, JS could not parse
functions. Now it can, so we don't need to name the function.

Up to you.

[vsm, 2017-05-23 20:52:55]

Are you updating the ddc version of html_dart2js.dart too?

Otherwise, LGTM

[Alan Knight, 2017-05-23 21:42:29]

On 2017/05/23 20:52:55, vsm wrote:
> Are you updating the ddc version of html_dart2js.dart too?
> 
> Otherwise, LGTM

I've been accumulating the changes separately, trying to get DDC to actually
pass. But I probably should start updating it incrementally. Will do it in a
separate CL, though.

[Alan Knight, 2017-05-23 21:42:37]

https://codereview.chromium.org/2896393002/diff/1/tools/dom/templates/html/im...
File tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate
(right):

https://codereview.chromium.org/2896393002/diff/1/tools/dom/templates/html/im...
tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate:109: return
JS('String', r'#.replace(/-([\da-z])/ig, #)', replacedMs, fToUpper);
On 2017/05/23 20:26:18, sra1 wrote:
> You could inline it here.
> 
> return JS('String',
>     r'#.replace(/-([\da-z])/ig, function(_, letter) { return
> letter.toUpperCase())',
>     replacedMs);
> 
> The whole reason for using JS_CONST was that originally, JS could not parse
> functions. Now it can, so we don't need to name the function.
> 
> Up to you.

Done.

[Alan Knight, 2017-05-23 21:48:14]

Description was changed from

==========
Remove JS_CONST from CssStyleDeclaration, causes DDC problems

BUG=
==========

to

==========
Remove JS_CONST from CssStyleDeclaration, causes DDC problems

BUG=
R=sra@google.com, vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e6c38ea30fa8c460b9d82038945c332ede51f79c
==========

[Alan Knight, 2017-05-23 21:48:15]

Committed patchset #1 (id:1) manually as
e6c38ea30fa8c460b9d82038945c332ede51f79c (presubmit successful).