Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4350)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2896303005: MD Settings: Allow searching the lock screen subpage. (Closed)
Patch Set: Fix id Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index 4fbf5aa143269b1adf969ebfc98714b8216b0024..75c19e80e3ba02372a9b51e5ab50a573e86fe463 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -190,8 +190,8 @@
</template>
<if expr="chromeos">
- <div class="settings-box two-line" actionable
- on-tap="onConfigureLockTap_">
+ <div id="lock-screen-subpage-trigger" class="settings-box two-line"
+ actionable on-tap="onConfigureLockTap_">
<div class="start">
$i18n{lockScreenTitle}
<div class="secondary" id="lockScreenSecondary">
@@ -199,7 +199,7 @@
prefs.settings.enable_screen_lock.value)]]
</div>
</div>
- <button id="lockScreenSubpageTrigger" class="subpage-arrow"
+ <button class="subpage-arrow"
is="paper-icon-button-light" aria-label="$i18n{lockScreenTitle}"
aria-describedby="lockScrenSecondary"></button>
</div>
@@ -242,8 +242,9 @@
</settings-subpage>
</template>
<if expr="chromeos">
- <template is="dom-if" route-path="/lockScreen" no-search>
- <settings-subpage page-title="$i18n{lockScreenTitle}">
+ <template is="dom-if" route-path="/lockScreen">
+ <settings-subpage page-title="$i18n{lockScreenTitle}"
+ associated-control="[[$$('#lock-screen-subpage-trigger')]]">
<settings-lock-screen
prefs="{{prefs}}">
</settings-lock-screen>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698