Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: src/inspector/v8-inspector-impl.cc

Issue 2896303004: [inspector] Move SetIdle from CPUProfiler to debug-interface (Closed)
Patch Set: rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug-interface.h ('k') | src/inspector/v8-profiler-agent-impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-inspector-impl.cc
diff --git a/src/inspector/v8-inspector-impl.cc b/src/inspector/v8-inspector-impl.cc
index 3e12c861d3af6bb51d4a0a4bd2dd92baa38a81b8..517aec683b8eaeea76d7079890c682e9bf1c0ba1 100644
--- a/src/inspector/v8-inspector-impl.cc
+++ b/src/inspector/v8-inspector-impl.cc
@@ -229,17 +229,9 @@ void V8InspectorImpl::resetContextGroup(int contextGroupId) {
m_debugger->wasmTranslation()->Clear();
}
-void V8InspectorImpl::idleStarted() {
- for (auto it = m_sessions.begin(); it != m_sessions.end(); ++it) {
- if (it->second->profilerAgent()->idleStarted()) return;
- }
-}
+void V8InspectorImpl::idleStarted() { v8::debug::SetIdle(m_isolate, true); }
-void V8InspectorImpl::idleFinished() {
- for (auto it = m_sessions.begin(); it != m_sessions.end(); ++it) {
- if (it->second->profilerAgent()->idleFinished()) return;
- }
-}
+void V8InspectorImpl::idleFinished() { v8::debug::SetIdle(m_isolate, false); }
unsigned V8InspectorImpl::exceptionThrown(
v8::Local<v8::Context> context, const StringView& message,
« no previous file with comments | « src/debug/debug-interface.h ('k') | src/inspector/v8-profiler-agent-impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698