Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2896293002: Disable benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_des… (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 56
57 # crbug.com/696824 57 # crbug.com/696824
58 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:news:qq', # pylint: disable=line-too-long 58 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:news:qq', # pylint: disable=line-too-long
59 59
60 # crbug.com/698006 60 # crbug.com/698006
61 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:drive', # pylint: disable=line-too-long 61 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:drive', # pylint: disable=line-too-long
62 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:gmail', # pylint: disable=line-too-long 62 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:gmail', # pylint: disable=line-too-long
63 63
64 # crbug.com/699966 64 # crbug.com/699966
65 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.multitab:misc:typical24', # pylint: disable=line-too-long 65 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.multitab:misc:typical24', # pylint: disable=line-too-long
66
67 # crbug.com/725386
68 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:social:twitter', # pylint: disable=line-too-long
66 }) 69 })
67 70
68 71
69 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): 72 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
70 73
71 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 74 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
72 # 75 #
73 # This smoke test dynamically tests all system health user stories. So 76 # This smoke test dynamically tests all system health user stories. So
74 # disabling it for one failing or flaky benchmark would disable a much 77 # disabling it for one failing or flaky benchmark would disable a much
75 # wider swath of coverage than is usally intended. Instead, if a test is 78 # wider swath of coverage than is usally intended. Instead, if a test is
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 # Prefetch WPR archive needed by the stories set to avoid race condition 163 # Prefetch WPR archive needed by the stories set to avoid race condition
161 # when feching them when tests are run in parallel. 164 # when feching them when tests are run in parallel.
162 # See crbug.com/700426 for more details. 165 # See crbug.com/700426 for more details.
163 stories_set.wpr_archive_info.DownloadArchivesIfNeeded() 166 stories_set.wpr_archive_info.DownloadArchivesIfNeeded()
164 167
165 for story_to_smoke_test in stories_set.stories: 168 for story_to_smoke_test in stories_set.stories:
166 suite.addTest( 169 suite.addTest(
167 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 170 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
168 171
169 return suite 172 return suite
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698