Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2896253003: Use the dart2js patch for dart:convert to get latest type fixes (Closed)

Created:
3 years, 7 months ago by vsm
Modified:
3 years, 7 months ago
Reviewers:
floitsch
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use the dart2js patch for dart:convert to get latest type fixes BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/6402ad477ddbd63c9aad37e624fb97f2afec9555

Patch Set 1 #

Total comments: 1

Patch Set 2 : Further type fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/convert_patch.dart View 1 10 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vsm
Patch set #1 is a direct copy of the dart2js version Patch set #2 has ...
3 years, 7 months ago (2017-05-24 00:02:18 UTC) #3
floitsch
Couldn't review. The review tool didn't show any sources.
3 years, 7 months ago (2017-05-24 13:39:13 UTC) #4
floitsch
Managed to make it work. LGTM. Could you please apply the type changes to the ...
3 years, 7 months ago (2017-05-24 13:42:44 UTC) #5
vsm
3 years, 7 months ago (2017-05-24 14:33:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
6402ad477ddbd63c9aad37e624fb97f2afec9555 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698