chrome/browser/win/jumplist_update_util.h - Issue 2896233003: Cancel the JumpList update if top 5 most visited URLs are unchanged

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/win/jumplist_update_util.h

Issue 2896233003: Cancel the JumpList update if top 5 most visited URLs are unchanged (Closed)

Patch Set: Add unittest Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
	grt (UTC plus 2) 2017/05/30 08:51:42 nit: omit "(c)" (https://chromium.googlesource.com nit: omit "(c)" (https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...) chengx 2017/05/30 19:37:02 Done. I also removed "(c)" for other header files. Show quoted text On 2017/05/30 08:51:42, grt (UTC plus 2) wrote: > nit: omit "(c)" > (https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...) Done. I also removed "(c)" for other header files.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_WIN_JUMPLIST_UPDATE_UTIL_H_

	6 #define CHROME_BROWSER_WIN_JUMPLIST_UPDATE_UTIL_H_

	7

	8 #include "chrome/browser/win/jumplist_updater.h"

	9 #include "components/history/core/browser/history_types.h"

	10

	11 // Checks if the urls stored in \|items\| are unchanged compared to the first

	12 // \|most_visited_items\| urls in \|urls\|.

	13 bool MostVisitedItemsUnchanged(const ShellLinkItemList& items,

	14 const history::MostVisitedURLList& urls,

	15 size_t most_visited_items);

	16

	17 #endif // CHROME_BROWSER_WIN_JUMPLIST_UPDATE_UTIL_H_

OLD	NEW