third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl - Issue 2896233002: Assert that ComputedStyleBase is only templated with ComputedStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

Issue 2896233002: Assert that ComputedStyleBase is only templated with ComputedStyle (Closed)

Patch Set: shend@'s suggestions Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

index cf15c37253a59730ff69800aec585d3adb73bf95..e9a3a90399113532bbf052ca17f5348476e2daf7 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

@@ -166,6 +166,7 @@ class CORE_EXPORT ComputedStyleBase {

{{field.name}}({{encode(field, field.default_value)}}){{print_if(not loop.last, ',')}}

{% endfor %}

{

+ static_assert(std::is_same<ComputedStyle, ComputedStyleFinal>::value, "ComputedStyleBase can only be templated with ComputedStyle");

alancutter (OOO until 2018) 2017/05/24 01:45:26 Woah magic.

{% for subgroup in computed_style.subgroups %}

{{subgroup.member_name}}.Init();

{% endfor %}

« no previous file with comments | « no previous file | no next file » | no next file with comments »