Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: net/base/network_change_notifier_unittest.cc

Issue 2896203003: [NetworkChangeNotifier] Return more specific network connection types (ethernet/wifi) on OSX (Closed)
Patch Set: Address issues from PS5 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/network_change_notifier_mac.cc ('k') | net/base/network_config_watcher_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/network_change_notifier_unittest.cc
diff --git a/net/base/network_change_notifier_unittest.cc b/net/base/network_change_notifier_unittest.cc
index c06d3588808eb95ec237b17a6b7afe438bd24f06..ef1563049df729abc3d676016b4312d9f95cffb2 100644
--- a/net/base/network_change_notifier_unittest.cc
+++ b/net/base/network_change_notifier_unittest.cc
@@ -105,6 +105,40 @@ TEST(NetworkChangeNotifierTest, IgnoreTeredoOnWindows) {
#endif
}
+TEST(NetworkChangeNotifierTest, IgnoreAirdropOnMac) {
+ NetworkInterfaceList list;
+ NetworkInterface interface_airdrop;
+ interface_airdrop.type = NetworkChangeNotifier::CONNECTION_ETHERNET;
+ interface_airdrop.name = "awdl0";
+ interface_airdrop.friendly_name = "awdl0";
+ list.push_back(interface_airdrop);
+
+#if defined(OS_MACOSX)
+ EXPECT_EQ(NetworkChangeNotifier::CONNECTION_NONE,
+ NetworkChangeNotifier::ConnectionTypeFromInterfaceList(list));
+#else
+ EXPECT_EQ(NetworkChangeNotifier::CONNECTION_ETHERNET,
+ NetworkChangeNotifier::ConnectionTypeFromInterfaceList(list));
+#endif
+}
+
+TEST(NetworkChangeNotifierTest, IgnoreTunnelsOnMac) {
+ NetworkInterfaceList list;
+ NetworkInterface interface_tunnel;
+ interface_tunnel.type = NetworkChangeNotifier::CONNECTION_ETHERNET;
+ interface_tunnel.name = "utun0";
+ interface_tunnel.friendly_name = "utun0";
+ list.push_back(interface_tunnel);
+
+#if defined(OS_MACOSX)
+ EXPECT_EQ(NetworkChangeNotifier::CONNECTION_NONE,
+ NetworkChangeNotifier::ConnectionTypeFromInterfaceList(list));
+#else
+ EXPECT_EQ(NetworkChangeNotifier::CONNECTION_ETHERNET,
+ NetworkChangeNotifier::ConnectionTypeFromInterfaceList(list));
+#endif
+}
+
TEST(NetworkChangeNotifierTest, IgnoreVMInterfaces) {
NetworkInterfaceList list;
NetworkInterface interface_vmnet_linux;
« no previous file with comments | « net/base/network_change_notifier_mac.cc ('k') | net/base/network_config_watcher_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698