Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: third_party/freetype/BUILD.gn

Issue 2896203002: Do not build FreeType with HarfBuzz support on Android (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/freetype/include/freetype-custom-config/ftoption.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/freetype/BUILD.gn
diff --git a/third_party/freetype/BUILD.gn b/third_party/freetype/BUILD.gn
index 08fc4f20bf23a54233aa32a5c36c6d89cad1542d..aeaa41c3922910200dc7c6aeef8b0f8a68bad7f3 100644
--- a/third_party/freetype/BUILD.gn
+++ b/third_party/freetype/BUILD.gn
@@ -120,6 +120,10 @@ component("freetype") {
# Selects those three modules in freetype-custom-config/ftmodule.h.
defines += [ "PDFIUM_REQUIRED_MODULES" ]
+ } else {
+ # Using HarfBuzz assisted autohinting has a performance impact that we do not
Dirk Pranke 2017/05/23 19:26:38 Nit: fix the line length / wrapping.
+ # want to take on Android, see crbug.com/724095.
+ defines += [ "WITHOUT_HARFBUZZ" ]
}
if (is_linux || is_chromecast) {
@@ -174,10 +178,12 @@ component("freetype") {
}
if (!use_system_harfbuzz) {
- deps += [
- "//third_party/harfbuzz-ng:harfbuzz-ng-ft",
- "//third_party/harfbuzz-ng:harfbuzz-ng-without-freetype",
- ]
+ if (!is_android) {
+ # See "WITHOUT_HARFBUZZ" above, harfbuzz-ng-ft is only needed if we build
+ # FreeType with HarfBuzz support.
+ deps += [ "//third_party/harfbuzz-ng:harfbuzz-ng-ft" ]
+ }
+ deps += [ "//third_party/harfbuzz-ng:harfbuzz-ng-without-freetype" ]
} else {
deps += [ "//third_party/harfbuzz-ng:harfbuzz-ng" ]
}
« no previous file with comments | « no previous file | third_party/freetype/include/freetype-custom-config/ftoption.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698