Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java

Issue 2896143002: Move batchedit related logics into InputConnection (Closed)
Patch Set: test fixed in another CL and rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java
index 68eb1c3a5415dea9bb65d87e0add53c0a1e88357..f5a0a2c3f37032fa78e8c3a4c767da8a635d9455 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java
@@ -396,10 +396,10 @@ public class UrlBarTest {
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- urlBar.beginBatchEdit();
+ urlBar.getInputConnection().beginBatchEdit();
urlBar.setText(textToBeEntered);
urlBar.setSelection(textToBeEntered.length());
- urlBar.endBatchEdit();
+ urlBar.getInputConnection().endBatchEdit();
}
});
autocompleteHelper.waitForCallback(0);
@@ -477,7 +477,7 @@ public class UrlBarTest {
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- urlBar.beginBatchEdit();
+ urlBar.getInputConnection().beginBatchEdit();
}
});
// Ensure the autocomplete is not modified if in batch mode.
@@ -488,7 +488,7 @@ public class UrlBarTest {
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- urlBar.endBatchEdit();
+ urlBar.getInputConnection().endBatchEdit();
}
});
@@ -527,7 +527,7 @@ public class UrlBarTest {
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- urlBar.beginBatchEdit();
+ urlBar.getInputConnection().beginBatchEdit();
}
});
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@@ -539,7 +539,7 @@ public class UrlBarTest {
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- urlBar.endBatchEdit();
+ urlBar.getInputConnection().endBatchEdit();
}
});
@@ -570,10 +570,10 @@ public class UrlBarTest {
// TODO(crbug.com/635567): Fix this properly.
@SuppressLint("SetTextI18n")
public void run() {
- urlBar.beginBatchEdit();
+ urlBar.getInputConnection().beginBatchEdit();
urlBar.setText("go");
urlBar.setSelection(2);
- urlBar.endBatchEdit();
+ urlBar.getInputConnection().endBatchEdit();
}
});
Assert.assertTrue(state.hasAutocomplete);
@@ -587,10 +587,10 @@ public class UrlBarTest {
// TODO(crbug.com/635567): Fix this properly.
@SuppressLint("SetTextI18n")
public void run() {
- urlBar.beginBatchEdit();
+ urlBar.getInputConnection().beginBatchEdit();
urlBar.setText("go");
urlBar.setSelection(0);
- urlBar.endBatchEdit();
+ urlBar.getInputConnection().endBatchEdit();
}
});
Assert.assertFalse(state.hasAutocomplete);
@@ -602,10 +602,10 @@ public class UrlBarTest {
// TODO(crbug.com/635567): Fix this properly.
@SuppressLint("SetTextI18n")
public void run() {
- urlBar.beginBatchEdit();
+ urlBar.getInputConnection().beginBatchEdit();
urlBar.setText("ga");
urlBar.setSelection(2);
- urlBar.endBatchEdit();
+ urlBar.getInputConnection().endBatchEdit();
}
});
Assert.assertFalse(state.hasAutocomplete);
@@ -617,10 +617,10 @@ public class UrlBarTest {
// TODO(crbug.com/635567): Fix this properly.
@SuppressLint("SetTextI18n")
public void run() {
- urlBar.beginBatchEdit();
+ urlBar.getInputConnection().beginBatchEdit();
urlBar.setText("googl");
urlBar.setSelection(5);
- urlBar.endBatchEdit();
+ urlBar.getInputConnection().endBatchEdit();
}
});
Assert.assertFalse(state.hasAutocomplete);

Powered by Google App Engine
This is Rietveld 408576698