Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: ash/login/lock_screen_controller_unittest.cc

Issue 2896093003: cros: Make sure views-based lock screen is destroyed after it is dismissed. (Closed)
Patch Set: Add new mojo calls Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/login/lock_screen_controller_unittest.cc
diff --git a/ash/login/lock_screen_controller_unittest.cc b/ash/login/lock_screen_controller_unittest.cc
index 3e42c9ee679438c372efa3643aa090e7051d6d41..45fec82779369f1e268332e4b23859cf02750db7 100644
--- a/ash/login/lock_screen_controller_unittest.cc
+++ b/ash/login/lock_screen_controller_unittest.cc
@@ -24,7 +24,7 @@ TEST_F(LockScreenControllerTest, RequestAuthentication) {
AccountId id = AccountId::FromUserEmail("user1@test.com");
// We hardcode the hashed password. This is fine because the password hash
- // algorithm should never accidently change; if it does we will need to
+ // algorithm should never accidentally change; if it does we will need to
// have cryptohome migration code and one failing test isn't a problem.
std::string password = "password";
std::string hashed_password = "40c7b00f3bccc7675ec5b732de4bfbe4";
@@ -32,8 +32,9 @@ TEST_F(LockScreenControllerTest, RequestAuthentication) {
// Verify AuthenticateUser mojo call is run with the same account id, a
// (hashed) password, and the correct PIN state.
- EXPECT_CALL(*client, AuthenticateUser(id, hashed_password, false));
- controller->AuthenticateUser(id, password, false);
+ EXPECT_CALL(*client, AuthenticateUser_(id, hashed_password, false, _));
+ controller->AuthenticateUser(id, password, false,
+ base::BindOnce([](bool auth_success) {}));
xiyuan 2017/06/06 22:37:51 nit: use mojom::LockScreenClient::AuthenticateUser
jdufault 2017/06/07 18:58:35 Done.
base::RunLoop().RunUntilIdle();
}

Powered by Google App Engine
This is Rietveld 408576698