Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Unified Diff: ash/login/ui/lock_screen.h

Issue 2896093003: cros: Make sure views-based lock screen is destroyed after it is dismissed. (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/login/ui/lock_contents_view.cc ('k') | ash/login/ui/lock_screen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/login/ui/lock_screen.h
diff --git a/ash/login/ui/lock_screen.h b/ash/login/ui/lock_screen.h
index fcccca615ae29945b5f6c25c0a8ecbde3d25fc2a..ecad2be6c448050f12ae54dc6f2d6f17a0a347c0 100644
--- a/ash/login/ui/lock_screen.h
+++ b/ash/login/ui/lock_screen.h
@@ -9,12 +9,19 @@
namespace ash {
+// TODO(jdufault): There's some internal state here so put ShowLockScreen and
+// DestroyLockScreen inside a (static) class, ie, ash::LockScreen::Show() and
+// ash::LockScreen::Destroy().
+
// Creates and displays the lock screen. Returns true if the lock screen was
// displayed.
//
// The lock screen communicates with the backend C++ via a mojo API.
ASH_EXPORT bool ShowLockScreen();
+// Destroys the lock screen. There must be an existing lock screen instance.
+ASH_EXPORT void DestroyLockScreen();
+
} // namespace ash
#endif // ASH_LOGIN_UI_LOCK_SCREEN_H_
« no previous file with comments | « ash/login/ui/lock_contents_view.cc ('k') | ash/login/ui/lock_screen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698