cros: Make sure views-based lock screen is destroyed after it is dismissed.

ash/login/lock_screen_controller_unittest.cc

Index: ash/login/lock_screen_controller_unittest.cc
diff --git a/ash/login/lock_screen_controller_unittest.cc b/ash/login/lock_screen_controller_unittest.cc
index a1c3debb5f67ab2b4d52b254cfe44653df3bcc42..b2cf6d263568e40ac39ddb612ced70d3ad9dfa3c 100644
--- a/ash/login/lock_screen_controller_unittest.cc
+++ b/ash/login/lock_screen_controller_unittest.cc
@@ -24,7 +24,7 @@ TEST_F(LockScreenControllerTest, RequestAuthentication) {
   AccountId id = AccountId::FromUserEmail("user1@test.com");
 
   // We hardcode the hashed password. This is fine because the password hash
-  // algorithm should never accidently change; if it does we will need to
+  // algorithm should never accidentally change; if it does we will need to
   // have cryptohome migration code and one failing test isn't a problem.
   std::string password = "password";
   std::string hashed_password = "40c7b00f3bccc7675ec5b732de4bfbe4";
@@ -32,8 +32,9 @@ TEST_F(LockScreenControllerTest, RequestAuthentication) {
 
   // Verify AuthenticateUser mojo call is run with the same account id, a
   // (hashed) password, and the correct PIN state.
-  EXPECT_CALL(*client, AuthenticateUser(id, hashed_password, false));
-  controller->AuthenticateUser(id, password, false);
+  EXPECT_CALL(*client, AuthenticateUser_(id, hashed_password, false, _));
+  controller->AuthenticateUser(
+      id, password, false, mojom::LockScreenClient::AuthenticateUserCallback());
 
   base::RunLoop().RunUntilIdle();
 }

[James Cook, 2017/06/08 19:47:12]

I think this test (or another test) should verify that the callback is actually
called.

[jdufault, 2017/06/08 22:23:14]

Done.