chrome/browser/chromeos/login/lock/webui_screen_locker.cc - Issue 2896093003: cros: Make sure views-based lock screen is destroyed after it is dismissed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/lock/webui_screen_locker.cc

Issue 2896093003: cros: Make sure views-based lock screen is destroyed after it is dismissed. (Closed)

Patch Set: Address comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/lock/webui_screen_locker.cc

diff --git a/chrome/browser/chromeos/login/lock/webui_screen_locker.cc b/chrome/browser/chromeos/login/lock/webui_screen_locker.cc

index d7f5cb14a2940383dd46409b19566c01a7016cab..b48de8e40b5fd795ac082f0a2371dc9945b93695 100644

--- a/chrome/browser/chromeos/login/lock/webui_screen_locker.cc

+++ b/chrome/browser/chromeos/login/lock/webui_screen_locker.cc

@@ -317,7 +317,8 @@ bool WebUIScreenLocker::IsSigninInProgress() const {

void WebUIScreenLocker::Login(const UserContext& user_context,

const SigninSpecifics& specifics) {

- chromeos::ScreenLocker::default_screen_locker()->Authenticate(user_context);

+ chromeos::ScreenLocker::default_screen_locker()->Authenticate(

+ user_context, ScreenLocker::AuthenticateCallback());

}

void WebUIScreenLocker::MigrateUserData(const std::string& old_password) {