Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: ash/login/lock_screen_controller.cc

Issue 2896093003: cros: Make sure views-based lock screen is destroyed after it is dismissed. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/login/ui/lock_screen.h » ('j') | ash/login/ui/lock_screen.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/login/lock_screen_controller.cc
diff --git a/ash/login/lock_screen_controller.cc b/ash/login/lock_screen_controller.cc
index 5ff835e034049bb50717f77809a1f13da4591d08..2cc4fdd8c7f1cf7d0d1926f52d3146262754f032 100644
--- a/ash/login/lock_screen_controller.cc
+++ b/ash/login/lock_screen_controller.cc
@@ -4,6 +4,7 @@
#include "ash/login/lock_screen_controller.h"
+#include "ash/login/ui/lock_screen.h"
#include "chromeos/cryptohome/system_salt_getter.h"
#include "chromeos/login/auth/user_context.h"
@@ -41,6 +42,11 @@ void LockScreenController::ShowErrorMessage(int32_t login_attempts,
void LockScreenController::ClearErrors() {
NOTIMPLEMENTED();
+
+ // TODO: At the moment, we don't have a notification that authentication has
+ // succeeded. ClearErrors is delivered though after login success so we reuse
+ // that. This should be done in a mojo call like AnimateAuthenticationSuccess.
+ DestroyLockScreen();
}
void LockScreenController::DoAuthenticateUser(const AccountId& account_id,
« no previous file with comments | « no previous file | ash/login/ui/lock_screen.h » ('j') | ash/login/ui/lock_screen.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698