Fix incremental kernel generator.

Fix incremental kernel generator.

Committed: https://github.com/dart-lang/sdk/commit/6715900e09e3e0be52b05d19159ca7a9315de629

[ahe, 2017-05-22 16:01:08]

ahe@google.com changed reviewers:
+ scheglov@google.com

[ahe, 2017-05-22 16:01:25]

TBR

[ahe, 2017-05-22 16:01:56]

Description was changed from

==========
Fix incremental kernel generator.
==========

to

==========
Fix incremental kernel generator.

Committed:
https://github.com/dart-lang/sdk/commit/6715900e09e3e0be52b05d19159ca7a9315de629
==========

[ahe, 2017-05-22 16:01:57]

Committed patchset #1 (id:1) manually as
6715900e09e3e0be52b05d19159ca7a9315de629 (presubmit successful).

[scheglov, 2017-05-22 16:05:06]

https://codereview.chromium.org/2896003002/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right):

https://codereview.chromium.org/2896003002/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:104: new
DillTarget(new Ticker(isVerbose: false), _uriTranslator, "vm");
Why not use new VmTarget() directly?
Why should we go through additional map lookup and use magic names anyway?

https://codereview.chromium.org/2896003002/diff/1/pkg/front_end/test/fasta/te...
File pkg/front_end/test/fasta/testing.json (right):

https://codereview.chromium.org/2896003002/diff/1/pkg/front_end/test/fasta/te...
pkg/front_end/test/fasta/testing.json:166: "analyze": {
What does analyze do?
Runs analyzer over the specified files? Folders?

[ahe, 2017-05-22 16:09:56]

https://codereview.chromium.org/2896003002/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental_kernel_generator_impl.dart (right):

https://codereview.chromium.org/2896003002/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental_kernel_generator_impl.dart:104: new
DillTarget(new Ticker(isVerbose: false), _uriTranslator, "vm");
On 2017/05/22 16:05:06, scheglov wrote:
> Why not use new VmTarget() directly?
> Why should we go through additional map lookup and use magic names anyway?

Because I'm assuming that this is an option that should be specified on the
command line.

https://codereview.chromium.org/2896003002/diff/1/pkg/front_end/test/fasta/te...
File pkg/front_end/test/fasta/testing.json (right):

https://codereview.chromium.org/2896003002/diff/1/pkg/front_end/test/fasta/te...
pkg/front_end/test/fasta/testing.json:166: "analyze": {
On 2017/05/22 16:05:06, scheglov wrote:
> What does analyze do?
> Runs analyzer over the specified files? Folders?

Both. To see the exact options passed to the analyzer, run this command:

./pkg/front_end/tool/fasta testing analyze --verbose

[ahe, 2017-05-31 13:50:28]

This CL was submitted TBR, but I still don't have an LGTM.

[scheglov, 2017-05-31 14:13:24]

lgtm