Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: pkg/front_end/lib/src/fasta/fasta.dart

Issue 2895983002: Read SDK and patches from a JSON file. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/fasta.dart
diff --git a/pkg/front_end/lib/src/fasta/fasta.dart b/pkg/front_end/lib/src/fasta/fasta.dart
index b6bc4707f3794f1aede92504d328aad9ac0eca24..3fe1be3d651ef0192551104c95d2241f86bbd208 100644
--- a/pkg/front_end/lib/src/fasta/fasta.dart
+++ b/pkg/front_end/lib/src/fasta/fasta.dart
@@ -124,8 +124,8 @@ class CompileTask {
}
Future<KernelTarget> buildOutline([Uri output]) async {
- TranslateUri uriTranslator = await TranslateUri.parse(
- c.fileSystem, c.options.sdk, c.options.packages);
+ TranslateUri uriTranslator = await TranslateUri
+ .parse(c.fileSystem, c.options.sdk, packages: c.options.packages);
ticker.logMs("Read packages file");
DillTarget dillTarget = createDillTarget(uriTranslator);
KernelTarget kernelTarget =
@@ -194,7 +194,7 @@ Future<CompilationResult> parseScriptInFileSystem(
Program program;
try {
TranslateUri uriTranslator =
- await TranslateUri.parse(fileSystem, null, packages);
+ await TranslateUri.parse(fileSystem, null, packages: packages);
final Ticker ticker = new Ticker(isVerbose: verbose);
final DillTarget dillTarget =
new DillTarget(ticker, uriTranslator, backendTarget);
@@ -252,7 +252,8 @@ Future compilePlatform(Uri patchedSdk, Uri fullOutput,
}
Future writeDepsFile(Uri script, Uri depsFile, Uri output,
- {Uri packages,
+ {Uri sdk,
+ Uri packages,
Uri platform,
Iterable<Uri> extraDependencies,
bool verbose: false,
@@ -265,9 +266,10 @@ Future writeDepsFile(Uri script, Uri depsFile, Uri output,
if (verbose) {
c.options.options["--verbose"] = true;
}
+ sdk ??= c.options.sdk;
- TranslateUri uriTranslator = await TranslateUri.parse(
- c.fileSystem, c.options.sdk, c.options.packages);
+ TranslateUri uriTranslator = await TranslateUri.parse(c.fileSystem, sdk,
+ packages: c.options.packages);
ticker.logMs("Read packages file");
DillTarget dillTarget =
new DillTarget(ticker, uriTranslator, backendTarget);

Powered by Google App Engine
This is Rietveld 408576698