third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html - Issue 2895963003: Apply layout-test-tidy to LayoutTests/webaudio

Unified Diff: third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html

Issue 2895963003: Apply layout-test-tidy to LayoutTests/webaudio (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html ('k') | third_party/WebKit/LayoutTests/webaudio/Gain/gain.html » ('j') | third_party/WebKit/LayoutTests/webaudio/tools/layout-test-tidy.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html b/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html

index 7ca1ea9dedba3682595286244aa1f76baafb0a7b..6fe3ed9da9490802762acb86f483ffa3f1da9a0a 100644

--- a/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html

+++ b/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html

@@ -1,75 +1,79 @@

-<!DOCTYPE HTML>

+<!DOCTYPE html>

<html>

<head>

+ <title>

+ dynamicscompressor-simple.html

+ </title>

- <script src="../../resources/testharnessreport.js"></script>

+ <script src="../../resources/testharnessreport.js"></script>

</head>

<body>

- <script>

- var audit = Audit.createTaskRunner();

- var context;

- var compressor;

- var sampleRate = 44100;

- var lengthInSeconds = 1;

- var renderedData;

- // This threshold experimentally determined. It depends on the the gain value of the gain node

- // below and the dynamics compressor. When the DynamicsCompressor had the pre-emphasis

- // filters, the peak value is about 0.21. Without it, the peak is about 0.84.

- var peakThreshold = 0.83;

+ <script id="layout-test-code">

+ let audit = Audit.createTaskRunner();

+ let context;

+ let compressor;

+ let sampleRate = 44100;

+ let lengthInSeconds = 1;

+ let renderedData;

+ // This threshold experimentally determined. It depends on the the gain

+ // value of the gain node below and the dynamics compressor. When the

+ // DynamicsCompressor had the pre-emphasis filters, the peak value is

+ // about 0.21. Without it, the peak is about 0.84.

+ let peakThreshold = 0.83;

function checkResult(renderedBuffer, should) {

renderedData = renderedBuffer.getChannelData(0);

// Search for a peak in the last part of the data.

- var startSample = sampleRate * (lengthInSeconds - .1);

- var endSample = renderedData.length;

- var k;

- var peak = -1;

+ let startSample = sampleRate * (lengthInSeconds - .1);

+ let endSample = renderedData.length;

+ let k;

+ let peak = -1;

for (k = startSample; k < endSample; ++k) {

- var sample = Math.abs(renderedData[k]);

+ let sample = Math.abs(renderedData[k]);

if (peak < sample)

- peak = sample;

+ peak = sample;

}

- should(peak >= peakThreshold, "Pre-emphasis effect not applied")

- .beTrue();

+ should(peak >= peakThreshold, 'Pre-emphasis effect not applied')

+ .beTrue();

- should(compressor.reduction !== 0,

- "Reduction value changed")

- .beTrue();

+ should(compressor.reduction !== 0, 'Reduction value changed').beTrue();

}

- audit.define({

- label: "test",

- description: "Test pre-emphasis in DynamicsCompressor is removed"

- }, function (task, should) {

+ audit.define(

+ {

+ label: 'test',

+ description: 'Test pre-emphasis in DynamicsCompressor is removed'

+ },

+ function(task, should) {

+ context = new OfflineAudioContext(

+ 1, sampleRate * lengthInSeconds, sampleRate);

+ // Connect an oscillator to a gain node to the compressor. The

+ // oscillator frequency is set to a high value for the (original)

+ // emphasis to kick in. The gain is a little extra boost to get the

+ // compressor enabled.

+ //

+ let osc = context.createOscillator();

+ osc.frequency.value = 15000;

+ let gain = context.createGain();

+ gain.gain.value = 1.5;

+ compressor = context.createDynamicsCompressor();

+ osc.connect(gain);

+ gain.connect(compressor);

+ compressor.connect(context.destination);

+ osc.start();

- context = new OfflineAudioContext(1, sampleRate * lengthInSeconds, sampleRate);

- // Connect an oscillator to a gain node to the compressor. The

- // oscillator frequency is set to a high value for the (original)

- // emphasis to kick in. The gain is a little extra boost to get the

- // compressor enabled.

- //

- var osc = context.createOscillator();

- osc.frequency.value = 15000;

- var gain = context.createGain();

- gain.gain.value = 1.5;

- compressor = context.createDynamicsCompressor();

- osc.connect(gain);

- gain.connect(compressor);

- compressor.connect(context.destination);

- osc.start();

+ context.startRendering()

+ .then(buffer => checkResult(buffer, should))

+ .then(() => task.done());

+ ;

+ });

- context.startRendering()

- .then(buffer => checkResult(buffer, should))

- .then(() => task.done());;

- });

audit.run();

</script>

</body>

</html>