third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-tail.html - Issue 2895963003: Apply layout-test-tidy to LayoutTests/webaudio

Unified Diff: third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-tail.html

Issue 2895963003: Apply layout-test-tidy to LayoutTests/webaudio (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-peaking.html ('k') | third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html » ('j') | third_party/WebKit/LayoutTests/webaudio/tools/layout-test-tidy.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-tail.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-tail.html b/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-tail.html

index 415050b947f89a9172988489271ed14b384e681f..2bb83cb266b174b56e7bf4f5ce990a650068ab1d 100644

--- a/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-tail.html

+++ b/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-tail.html

@@ -1,64 +1,69 @@

-<!doctype html>

+<!DOCTYPE html>

<html>

<head>

- <title>Test Biquad Tail Output</title>

+ <title>

+ Test Biquad Tail Output

+ </title>

- <script src="../../resources/testharnessreport.js"></script>

+ <script src="../../resources/testharnessreport.js"></script>

</head>

<body>

- <script>

+ <script id="layout-test-code">

let audit = Audit.createTaskRunner();

// A high sample rate shows the issue more clearly.

let sampleRate = 192000;

- // Some short duration because we don't need to run the test for very long.

+ // Some short duration because we don't need to run the test for very

+ // long.

let testDurationSec = 0.5;

let testDurationFrames = testDurationSec * sampleRate;

- // Amplitude experimentally determined to give a biquad output close to 1. (No attempt was

- // made to produce exactly 1; it's not needed.)

+ // Amplitude experimentally determined to give a biquad output close to 1.

+ // (No attempt was made to produce exactly 1; it's not needed.)

let sourceAmplitude = 100;

- // The output of the biquad filter should not change by more than this much between output

- // samples. Threshold was determined experimentally.

+ // The output of the biquad filter should not change by more than this

+ // much between output samples. Threshold was determined experimentally.

let glitchThreshold = 0.012968;

- // Test that a Biquad filter doesn't have it's output terminated because the input has gone

- // away. Generally, when a source node is finished, it disconnects itself from any downstream

- // nodes. This is the correct behavior. Nodes that have no inputs (disconnected) are

- // generally assumed to output zeroes. This is also desired behavior. However, biquad

- // filters have memory so they should not suddenly output zeroes when the input is

- // disconnected. This test checks to see if the output doesn't suddenly change to zero.

- audit.define({

- label: "test",

- description: "Biquad Tail Output"

- }, function (task, should) {

- let context = new OfflineAudioContext(1, testDurationFrames, sampleRate);

+ // Test that a Biquad filter doesn't have it's output terminated because

+ // the input has gone away. Generally, when a source node is finished, it

+ // disconnects itself from any downstream nodes. This is the correct

+ // behavior. Nodes that have no inputs (disconnected) are generally

+ // assumed to output zeroes. This is also desired behavior. However,

+ // biquad filters have memory so they should not suddenly output zeroes

+ // when the input is disconnected. This test checks to see if the output

+ // doesn't suddenly change to zero.

+ audit.define(

+ {label: 'test', description: 'Biquad Tail Output'},

+ function(task, should) {

+ let context =

+ new OfflineAudioContext(1, testDurationFrames, sampleRate);

- // Create an impulse source.

- let buffer = context.createBuffer(1, 1, context.sampleRate);

- buffer.getChannelData(0)[0] = sourceAmplitude;

- let source = context.createBufferSource();

- source.buffer = buffer;

+ // Create an impulse source.

+ let buffer = context.createBuffer(1, 1, context.sampleRate);

+ buffer.getChannelData(0)[0] = sourceAmplitude;

+ let source = context.createBufferSource();

+ source.buffer = buffer;

- // Create the biquad filter. It doesn't really matter what kind, so the default filter type

- // and parameters is fine. Connect the source to it.

- let biquad = context.createBiquadFilter();

- source.connect(biquad);

- biquad.connect(context.destination);

+ // Create the biquad filter. It doesn't really matter what kind, so

+ // the default filter type and parameters is fine. Connect the

+ // source to it.

+ let biquad = context.createBiquadFilter();

+ source.connect(biquad);

+ biquad.connect(context.destination);

- source.start();

+ source.start();

- context.startRendering().then(function(result) {

- // There should be no large discontinuities in the output

- should(result.getChannelData(0), "Biquad output")

- .notGlitch(glitchThreshold);

- task.done();

- })

- });

+ context.startRendering().then(function(result) {

+ // There should be no large discontinuities in the output

+ should(result.getChannelData(0), 'Biquad output')

+ .notGlitch(glitchThreshold);

+ task.done();

+ })

+ });

audit.run();

</script>