Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html

Issue 2895963003: Apply layout-test-tidy to LayoutTests/webaudio (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html
index 50e000a0a56d85d1713717e4c2758720cfbe9eb4..1e0bd7fe0e043aa3001d422d13de667dc25abe41 100644
--- a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html
+++ b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html
@@ -1,40 +1,43 @@
-<!doctype html>
+<!DOCTYPE html>
<html>
<head>
+ <title>
+ Test Sampling for SetTargetAtTime
+ </title>
<script src="../../resources/testharness.js"></script>
- <script src="../../resources/testharnessreport.js"></script>
+ <script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
<script src="../resources/audit.js"></script>
<script src="../resources/audioparam-testing.js"></script>
- <title>Test Sampling for SetTargetAtTime</title>
</head>
-
<body>
- <script>
-
+ <script id="layout-test-code">
// Some slow sample rate, but otherwise arbitrary.
- var sampleRate = 12800;
-
- // Time constant for setTargetValue. Make it short, but is otherwise arbitrary.
- var timeConstant = 10 / sampleRate;
-
- // Defaut initial gain for test. Arbitrary, but we want it large so the changes look large,
- // even if the relative change isn't.
- var initialGain = 10000;
-
- var audit = Audit.createTaskRunner();
-
- // Test sampling of setTargetAtTime that starts at |startFrame|. A gain node is used for
- // testing. |initializeGainFunction| initializes the gain value.
- function doTest(should, message, startFrame, threshold, initializeGainFunction) {
- var context = new OfflineAudioContext(1, 256, sampleRate);
- var source = context.createBufferSource();
- var b = context.createBuffer(1, 1, sampleRate);
+ let sampleRate = 12800;
+
+ // Time constant for setTargetValue. Make it short, but is otherwise
+ // arbitrary.
+ let timeConstant = 10 / sampleRate;
+
+ // Defaut initial gain for test. Arbitrary, but we want it large so the
+ // changes look large, even if the relative change isn't.
+ let initialGain = 10000;
+
+ let audit = Audit.createTaskRunner();
+
+ // Test sampling of setTargetAtTime that starts at |startFrame|. A gain
+ // node is used for testing. |initializeGainFunction| initializes the
+ // gain value.
+ function doTest(
+ should, message, startFrame, threshold, initializeGainFunction) {
+ let context = new OfflineAudioContext(1, 256, sampleRate);
+ let source = context.createBufferSource();
+ let b = context.createBuffer(1, 1, sampleRate);
b.getChannelData(0)[0] = 1;
source.buffer = b;
source.loop = true;
- var gain = context.createGain();
+ let gain = context.createGain();
// Initialize the value of the gain node appropriately.
initializeGainFunction(gain);
gain.gain.setTargetAtTime(0, startFrame / sampleRate, timeConstant);
@@ -44,62 +47,71 @@
source.start();
- return context.startRendering().then(function (resultBuffer) {
- // Verify that the sampling of the setTargetAtTime automation was done correctly. We just
- // look at the sample just past the start of the automation.
- var resultData = resultBuffer.getChannelData(0);
- // Compute the true result at the frame just past startFrame and verify that the actual
- // rendered result is within |threshold| of the expected value.
- var frame = Math.ceil(startFrame);
- var v = 10000 * Math.exp(-(frame / sampleRate - startFrame / sampleRate) / timeConstant);
- should(resultData[frame], message + ": Target value at frame " +
- frame).beCloseTo(v, {
- threshold: threshold
- });
+ return context.startRendering().then(function(resultBuffer) {
+ // Verify that the sampling of the setTargetAtTime automation was done
+ // correctly. We just look at the sample just past the start of the
+ // automation.
+ let resultData = resultBuffer.getChannelData(0);
+ // Compute the true result at the frame just past startFrame and
+ // verify that the actual rendered result is within |threshold| of the
+ // expected value.
+ let frame = Math.ceil(startFrame);
+ let v = 10000 *
+ Math.exp(
+ -(frame / sampleRate - startFrame / sampleRate) /
+ timeConstant);
+ should(
+ resultData[frame], message + ': Target value at frame ' + frame)
+ .beCloseTo(v, {threshold: threshold});
});
}
- function initializeGainBySetter (g) {
+ function initializeGainBySetter(g) {
g.gain.value = initialGain;
}
- function initializeGainBySetValue (g) {
+ function initializeGainBySetValue(g) {
g.gain.setValueAtTime(initialGain, 0);
}
- audit.define("setValue;128.1", (task, should) => {
- doTest(should, "Initialize by setValueAtTime", 128.1, 3.6029e-8,
+ audit.define('setValue;128.1', (task, should) => {
+ doTest(
+ should, 'Initialize by setValueAtTime', 128.1, 3.6029e-8,
initializeGainBySetValue)
- .then(() => task.done());
+ .then(() => task.done());
});
- audit.define("setValue;0.1", (task, should) => {
- doTest(should, "Initialize by setValueAtTime", 0.1, 3.6029e-8,
+ audit.define('setValue;0.1', (task, should) => {
+ doTest(
+ should, 'Initialize by setValueAtTime', 0.1, 3.6029e-8,
initializeGainBySetValue)
- .then(() => task.done());
+ .then(() => task.done());
});
- audit.define("setValue;0.0", (task, should) => {
- doTest(should, "Initialize by setValueAtTime", 0, 3.6029e-8,
+ audit.define('setValue;0.0', (task, should) => {
+ doTest(
+ should, 'Initialize by setValueAtTime', 0, 3.6029e-8,
initializeGainBySetValue)
- .then(() => task.done());
+ .then(() => task.done());
});
- audit.define("setter;128.1", (task, should) => {
- doTest(should, "Initialize by setter", 128.1, 3.6029e-8,
+ audit.define('setter;128.1', (task, should) => {
+ doTest(
+ should, 'Initialize by setter', 128.1, 3.6029e-8,
initializeGainBySetter)
- .then(() => task.done());
+ .then(() => task.done());
});
- audit.define("setter;0.1", (task, should) => {
- doTest(should, "Initialize by setter", 0.1, 3.6029e-8,
+ audit.define('setter;0.1', (task, should) => {
+ doTest(
+ should, 'Initialize by setter', 0.1, 3.6029e-8,
initializeGainBySetter)
- .then(() => task.done());
+ .then(() => task.done());
});
- audit.define("setter;0.0", (task, should) => {
- doTest(should, "Initialize by setter", 0, 0, initializeGainBySetter)
- .then(() => task.done());
+ audit.define('setter;0.0', (task, should) => {
+ doTest(should, 'Initialize by setter', 0, 0, initializeGainBySetter)
+ .then(() => task.done());
});
audit.run();

Powered by Google App Engine
This is Rietveld 408576698