third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html - Issue 2895963003: Apply layout-test-tidy to LayoutTests/webaudio

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html

Issue 2895963003: Apply layout-test-tidy to LayoutTests/webaudio (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-downmix.html ('k') | third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-sizing.html » ('j') | third_party/WebKit/LayoutTests/webaudio/tools/layout-test-tidy.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html

index d32d841608f2e638503bb0bc9cac8c77cc2f736e..d9107abb4ea92100754ee4ff6a8c94b945f4b046 100644

--- a/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html

+++ b/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html

@@ -1,17 +1,18 @@

-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

+<!DOCTYPE html>

<html>

<head>

+ <title>

+ realtimeanalyser-fft-scaling.html

+ </title>

</head>

<body>

- <script>

+ <script id="layout-test-code">

let audit = Audit.createTaskRunner();

// The number of analysers. We have analysers from size for each of the

@@ -20,71 +21,77 @@

let sampleRate = 44100;

let nyquistFrequency = sampleRate / 2;

- // Frequency of the sine wave test signal. Should be high enough so that we get at least one

- // full cycle for the 32-point FFT. This should also be such that the frequency should be

- // exactly in one of the FFT bins for each of the possible FFT sizes.

- let oscFrequency = nyquistFrequency/16;

+ // Frequency of the sine wave test signal. Should be high enough so that

+ // we get at least one full cycle for the 32-point FFT. This should also

+ // be such that the frequency should be exactly in one of the FFT bins for

+ // each of the possible FFT sizes.

+ let oscFrequency = nyquistFrequency / 16;

- // The actual peak values from each analyser. Useful for examining the results in Chrome.

+ // The actual peak values from each analyser. Useful for examining the

+ // results in Chrome.

let peakValue = new Array(numberOfAnalysers);

- // For a 0dBFS sine wave, we would expect the FFT magnitude to be 0dB as well, but the

- // analyzer node applies a Blackman window (to smooth the estimate). This reduces the energy

- // of the signal so the FFT peak is less than 0dB. The threshold value given here was

- // determined experimentally.

+ // For a 0dBFS sine wave, we would expect the FFT magnitude to be 0dB as

+ // well, but the analyzer node applies a Blackman window (to smooth the

+ // estimate). This reduces the energy of the signal so the FFT peak is

+ // less than 0dB. The threshold value given here was determined

+ // experimentally.

// See https://code.google.com/p/chromium/issues/detail?id=341596.

- let peakThreshold = [-14.43, -13.56, -13.56, -13.56, -13.56, -13.56,

- -13.56, -13.56, -13.56, -13.56, -13.56

+ let peakThreshold = [

+ -14.43, -13.56, -13.56, -13.56, -13.56, -13.56, -13.56, -13.56, -13.56,

+ -13.56, -13.56

];

function checkResult(order, analyser, should) {

- return function () {

- let index = order - 5;

- let fftSize = 1 << order;

- let fftData = new Float32Array(fftSize);

- analyser.getFloatFrequencyData(fftData);

- // Compute the frequency bin that should contain the peak.

- let expectedBin = analyser.frequencyBinCount * (oscFrequency / nyquistFrequency);

- // Find the actual bin by finding the bin containing the peak.

- let actualBin = 0;

- peakValue[index] = -1000;

- for (k = 0; k < analyser.frequencyBinCount; ++k) {

- if (fftData[k] > peakValue[index]) {

- actualBin = k;

- peakValue[index] = fftData[k];

- }

+ return function() {

+ let index = order - 5;

+ let fftSize = 1 << order;

+ let fftData = new Float32Array(fftSize);

+ analyser.getFloatFrequencyData(fftData);

+ // Compute the frequency bin that should contain the peak.

+ let expectedBin =

+ analyser.frequencyBinCount * (oscFrequency / nyquistFrequency);

+ // Find the actual bin by finding the bin containing the peak.

+ let actualBin = 0;

+ peakValue[index] = -1000;

+ for (k = 0; k < analyser.frequencyBinCount; ++k) {

+ if (fftData[k] > peakValue[index]) {

+ actualBin = k;

+ peakValue[index] = fftData[k];

+ }

- should(actualBin, (1 << order) + "-point FFT peak position")

- .beEqualTo(expectedBin);

+ should(actualBin, (1 << order) + '-point FFT peak position')

+ .beEqualTo(expectedBin);

- should(peakValue[index], (1 << order) +

- "-point FFT peak value in dBFS")

- .beGreaterThanOrEqualTo(peakThreshold[index]);

- }

+ should(

+ peakValue[index], (1 << order) + '-point FFT peak value in dBFS')

+ .beGreaterThanOrEqualTo(peakThreshold[index]);

+ }

}

- audit.define({

- label: "FFT scaling tests",

- description: "Test Scaling of FFT in AnalyserNode"

- }, function (task, should) {

- let tests = [];

- for (let k = 5; k <= 15; ++k)

- tests.push(runTest(k, should));

- // The order in which the tests finish is not important.

- Promise.all(tests)

- .then(task.done.bind(task));

- });

+ audit.define(

+ {

+ label: 'FFT scaling tests',

+ description: 'Test Scaling of FFT in AnalyserNode'

+ },

+ function(task, should) {

+ let tests = [];

+ for (let k = 5; k <= 15; ++k)

+ tests.push(runTest(k, should));

+ // The order in which the tests finish is not important.

+ Promise.all(tests).then(task.done.bind(task));

+ });

function runTest(order, should) {

let context = new OfflineAudioContext(1, 1 << order, sampleRate);

// Use a sine wave oscillator as the reference source signal.

let osc = context.createOscillator();

- osc.type = "sine";

+ osc.type = 'sine';

osc.frequency.value = oscFrequency;

osc.connect(context.destination);

@@ -96,10 +103,9 @@

osc.start();

context.oncomplete = checkResult(order, analyser, should);

- return context.startRendering()

- .then(function (audioBuffer) {

- checkResult(audioBuffer, order, analyser);

- });

+ return context.startRendering().then(function(audioBuffer) {

+ checkResult(audioBuffer, order, analyser);

+ });

}

audit.run();