Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: components/download/internal/model.h

Issue 2895953004: Add initial Controller to DownloadService (Closed)
Patch Set: Moved stats out Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/download/internal/model.h
diff --git a/components/download/internal/model.h b/components/download/internal/model.h
index ce5de88e4500878f1f7667c461b30cfb53991144..491627a660340be8742fa3a6c2c234853b2c6efb 100644
--- a/components/download/internal/model.h
+++ b/components/download/internal/model.h
@@ -30,12 +30,12 @@ class Model {
// |success| is |false|, initialization of the Model and/or the underlying
// Store failed. Initialization of the Model is complete after this
// callback. If |success| is true it can be accessed now.
- virtual void OnInitialized(bool success) = 0;
+ virtual void OnModelReady(bool success) = 0;
// Called asynchronously in response to a Model::Destroy call. If |success|
// is |false|, destruction of the Model and/or the underlying Store failed.
// Destruction of the Model is effectively complete after this callback.
- virtual void OnDestroyed(bool success) = 0;
+ virtual void OnModelDestroyed(bool success) = 0;
xingliu 2017/05/27 00:25:32 fyi: Destroy call probably will be removed in rece
David Trainor- moved to gerrit 2017/05/30 18:55:23 Yeah. Will remove this. Will wait for that CL to
// Called when an Entry addition is complete. |success| determines whether
// or not the entry has been successfully persisted to the Store.
@@ -62,7 +62,7 @@ class Model {
// Initializes the Model. Client::OnInitialized() will be called in response.
// The Model can be used after that call.
- virtual void Initialize() = 0;
+ virtual void Initialize(Client* client) = 0;
// Destroys the Model. Client::OnDestroyed() will be called in response.
virtual void Destroy() = 0;

Powered by Google App Engine
This is Rietveld 408576698