Use SkJpegEncoder in gfx jpeg_codec

components/suggestions/image_encoder.cc

Index: components/suggestions/image_encoder.cc
diff --git a/components/suggestions/image_encoder.cc b/components/suggestions/image_encoder.cc
index 8b0fa09fc260d64b8df3bc12cf5499dd017f604e..d99d1fcfc26542162d8750af2d5f2ab604d2643b 100644
--- a/components/suggestions/image_encoder.cc
+++ b/components/suggestions/image_encoder.cc
@@ -20,10 +20,12 @@ bool EncodeSkBitmapToJPEG(const SkBitmap& bitmap,
   if (!bitmap.readyToDraw() || bitmap.isNull()) {
     return false;
   }
-  return gfx::JPEGCodec::Encode(
-      reinterpret_cast<unsigned char*>(bitmap.getAddr32(0, 0)),
-      gfx::JPEGCodec::FORMAT_SkBitmap, bitmap.width(), bitmap.height(),
-      bitmap.rowBytes(), 100, dest);
+
+  SkPixmap pixmap;
+  bool success = bitmap.peekPixels(&pixmap);
+  DCHECK(success);

[scroggo_chromium, 2017/06/07 18:43:56]

It's too bad these three lines get repeated so much. I suppose the best fix is
to (eventually) convert callers away from SkBitmap and we won't need them?

[msarett1, 2017/06/07 20:51:10]

That seems right to me.  I considered adding an additional API that took an
SkBitmap as a convenience, but I didn't want to encourage more uses of SkBitmap.

+
+  return gfx::JPEGCodec::Encode(pixmap, 100, dest);
 }
 
 }  // namespace suggestions