Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/dom/DOMTokenList.h

Issue 2895903002: DOMTokenList: Update serialization algorithm on add()/remove() (Closed)
Patch Set: Remove one -expected.txt Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DOMTokenList.h
diff --git a/third_party/WebKit/Source/core/dom/DOMTokenList.h b/third_party/WebKit/Source/core/dom/DOMTokenList.h
index 5a51766ae860edbf808b1db912d4cfbae10b79b2..262fc3471b14b800fe4d872ffea377afe7581052 100644
--- a/third_party/WebKit/Source/core/dom/DOMTokenList.h
+++ b/third_party/WebKit/Source/core/dom/DOMTokenList.h
@@ -73,6 +73,7 @@ class CORE_EXPORT DOMTokenList : public GarbageCollectedFinalized<DOMTokenList>,
virtual void setValue(const AtomicString&);
const SpaceSplitString& Tokens() const { return tokens_; }
+ virtual SpaceSplitString& MutableSet() { return tokens_; }
kochi 2017/05/24 05:46:00 How about moving this to protected: section?
tkent 2017/05/24 06:05:34 It's reasonable. Done.
void SetObserver(DOMTokenListObserver* observer) { observer_ = observer; }
const AtomicString& toString() const { return value(); }
@@ -89,10 +90,11 @@ class CORE_EXPORT DOMTokenList : public GarbageCollectedFinalized<DOMTokenList>,
bool ValidateToken(const String&, ExceptionState&) const;
bool ValidateTokens(const Vector<String>&, ExceptionState&) const;
virtual bool ValidateTokenValue(const AtomicString&, ExceptionState&) const;
- static AtomicString AddToken(const AtomicString&, const AtomicString&);
- static AtomicString AddTokens(const AtomicString&, const Vector<String>&);
- static AtomicString RemoveToken(const AtomicString&, const AtomicString&);
- static AtomicString RemoveTokens(const AtomicString&, const Vector<String>&);
+ AtomicString AddToken(const AtomicString&);
+ AtomicString AddTokens(const Vector<String>&);
+ AtomicString RemoveToken(const AtomicString&);
+ AtomicString RemoveTokens(const Vector<String>&);
+ static AtomicString SerializeSet(const SpaceSplitString&);
private:
SpaceSplitString tokens_;

Powered by Google App Engine
This is Rietveld 408576698