third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp - Issue 2895883002: Make TextEmphasisPosition an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

Issue 2895883002: Make TextEmphasisPosition an enum class. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

index 350cb97c1cbd11be2b0dc5ee215b6632dd4fe52c..0fa8c6889a18b8e6a5f198511b3545b5e1f8c238 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

@@ -495,7 +495,7 @@ bool InlineTextBox::GetEmphasisMarkPosition(

emphasis_position = style.GetTextEmphasisPosition();

// Ruby text is always over, so it cannot suppress emphasis marks under.

- if (emphasis_position == kTextEmphasisPositionUnder)

+ if (emphasis_position == TextEmphasisPosition::kUnder)

return true;

LineLayoutBox containing_block = GetLineLayoutItem().ContainingBlock();