Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2895853003: [mac] Use the host platform's strip command (Closed)

Created:
3 years, 7 months ago by zra
Modified:
3 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[mac] Use the host platform's strip command The strip command from the clang toolchain is mangling the binary somehow Committed: https://github.com/dart-lang/sdk/commit/61b6525c0bfa63783fe0469eb56a96d100af97d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/toolchain/mac/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 7 months ago (2017-05-22 18:02:27 UTC) #2
zra
TBR
3 years, 7 months ago (2017-05-22 18:34:14 UTC) #3
zra
Committed patchset #1 (id:1) manually as 61b6525c0bfa63783fe0469eb56a96d100af97d3 (presubmit successful).
3 years, 7 months ago (2017-05-22 18:34:39 UTC) #5
rmacnak
3 years, 7 months ago (2017-05-22 19:26:37 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698