add fasta.scanner support for lazy assignment operators

add fasta.scanner support for lazy assignment operators

R=paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/3c447ab35dc3a6e523b64f1a34eaac7d42af4601

[danrubel, 2017-05-20 03:03:47]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[Paul Berry, 2017-05-20 13:57:09]

paulberry@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2017-05-20 13:57:10]

lgtm assuming comments are addressed

https://codereview.chromium.org/2895803002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/scanner.dart (right):

https://codereview.chromium.org/2895803002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/scanner.dart:86: scanner.scanLazyAssignmentOperators
= scanLazyAssignmentOperators;
Why not pass this in to the constructor like we do with includeComments and
scanGenericMethodComments?

https://codereview.chromium.org/2895803002/diff/1/pkg/front_end/test/scanner_...
File pkg/front_end/test/scanner_fasta_test.dart (left):

https://codereview.chromium.org/2895803002/diff/1/pkg/front_end/test/scanner_...
pkg/front_end/test/scanner_fasta_test.dart:33: // TODO(paulberry): once
lazyAssignmentOperators are fully supported by
Don't remove this TODO--it still applies (we should still remove the
`lazyAssignmentOperators` flag once they are fully supported by Dart)

https://codereview.chromium.org/2895803002/diff/1/pkg/front_end/test/scanner_...
File pkg/front_end/test/scanner_replacement_test.dart (left):

https://codereview.chromium.org/2895803002/diff/1/pkg/front_end/test/scanner_...
pkg/front_end/test/scanner_replacement_test.dart:40: // TODO(danrubel): once
lazyAssignmentOperators are fully supported by
Same here

[scheglov, 2017-05-20 16:00:45]

LGTM

[danrubel, 2017-05-20 21:17:04]

https://codereview.chromium.org/2895803002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/scanner.dart (right):

https://codereview.chromium.org/2895803002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/scanner.dart:86: scanner.scanLazyAssignmentOperators
= scanLazyAssignmentOperators;
On 2017/05/20 13:57:09, Paul Berry wrote:
> Why not pass this in to the constructor like we do with includeComments and
> scanGenericMethodComments?

Good point. Done.

https://codereview.chromium.org/2895803002/diff/1/pkg/front_end/test/scanner_...
File pkg/front_end/test/scanner_fasta_test.dart (left):

https://codereview.chromium.org/2895803002/diff/1/pkg/front_end/test/scanner_...
pkg/front_end/test/scanner_fasta_test.dart:33: // TODO(paulberry): once
lazyAssignmentOperators are fully supported by
On 2017/05/20 13:57:10, Paul Berry wrote:
> Don't remove this TODO--it still applies (we should still remove the
> `lazyAssignmentOperators` flag once they are fully supported by Dart)

Good point. I moved the comment from here to the
fasta.scanner.scanLazyAssignmentOperators field because we probably want to
remove that field and all direct and indirect references once the language has
been updated.

[Paul Berry, 2017-05-21 00:37:10]

lgtm

[danrubel, 2017-05-21 03:02:52]

Description was changed from

==========
add fasta.scanner support for lazy assignment operators
==========

to

==========
add fasta.scanner support for lazy assignment operators

R=paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3c447ab35dc3a6e523b64f1a34eaac7d42af4601
==========

[danrubel, 2017-05-21 03:02:54]

Committed patchset #2 (id:20001) manually as
3c447ab35dc3a6e523b64f1a34eaac7d42af4601 (presubmit successful).

[ahe, 2017-05-22 11:37:37]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-05-22 11:37:38]

https://codereview.chromium.org/2895803002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart (right):

https://codereview.chromium.org/2895803002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart:42: bool
scanLazyAssignmentOperators = false;
Why are we adding this flag?

[danrubel, 2017-05-23 11:33:40]

https://codereview.chromium.org/2895803002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart (right):

https://codereview.chromium.org/2895803002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart:42: bool
scanLazyAssignmentOperators = false;
On 2017/05/22 11:37:38, ahe wrote:
> Why are we adding this flag?

AFAIK, the language does not yet support lazy assignment operators, thus the
flag. I'm updating the fasta scanner to provide the same functionality that the
analyzer scanner does so that I can delete the analyzer scanner.

That said, we could roll this back and remove this functionality until closer to
the time that these language features are supported.

[ahe, 2017-05-23 11:46:08]

https://codereview.chromium.org/2895803002/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart (right):

https://codereview.chromium.org/2895803002/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart:42: bool
scanLazyAssignmentOperators = false;
On 2017/05/23 11:33:40, danrubel wrote:
> On 2017/05/22 11:37:38, ahe wrote:
> > Why are we adding this flag?
> 
> AFAIK, the language does not yet support lazy assignment operators, thus the
> flag. I'm updating the fasta scanner to provide the same functionality that
the
> analyzer scanner does so that I can delete the analyzer scanner.
> 
> That said, we could roll this back and remove this functionality until closer
to
> the time that these language features are supported.

I don't think the flag is necessary. The parser will report an error on &&= or
||= regardless of how they're tokenized.

[danrubel, 2017-05-24 19:51:26]

On 2017/05/23 11:46:08, ahe wrote:
>
https://codereview.chromium.org/2895803002/diff/20001/pkg/front_end/lib/src/f...
> File pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart (right):
> 
>
https://codereview.chromium.org/2895803002/diff/20001/pkg/front_end/lib/src/f...
> pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart:42: bool
> scanLazyAssignmentOperators = false;
> On 2017/05/23 11:33:40, danrubel wrote:
> > On 2017/05/22 11:37:38, ahe wrote:
> > > Why are we adding this flag?
> > 
> > AFAIK, the language does not yet support lazy assignment operators, thus the
> > flag. I'm updating the fasta scanner to provide the same functionality that
> the
> > analyzer scanner does so that I can delete the analyzer scanner.
> > 
> > That said, we could roll this back and remove this functionality until
closer
> to
> > the time that these language features are supported.
> 
> I don't think the flag is necessary. The parser will report an error on &&= or
> ||= regardless of how they're tokenized.

https://codereview.chromium.org/2903063003/