Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: cc/trees/property_tree.cc

Issue 2895793002: Track transform animation content readiness on TransformNode. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 186
187 bool TransformTree::OnTransformAnimated(ElementId element_id, 187 bool TransformTree::OnTransformAnimated(ElementId element_id,
188 const gfx::Transform& transform) { 188 const gfx::Transform& transform) {
189 TransformNode* node = FindNodeFromElementId(element_id); 189 TransformNode* node = FindNodeFromElementId(element_id);
190 DCHECK(node); 190 DCHECK(node);
191 if (node->local == transform) 191 if (node->local == transform)
192 return false; 192 return false;
193 node->local = transform; 193 node->local = transform;
194 node->needs_local_transform_update = true; 194 node->needs_local_transform_update = true;
195 node->transform_changed = true; 195 node->transform_changed = true;
196 node->ready_since_animation = false;
wkorman 2017/05/20 01:31:27 Is it ok that we do this on both main and impl thr
196 property_trees()->changed = true; 197 property_trees()->changed = true;
197 set_needs_update(true); 198 set_needs_update(true);
198 return true; 199 return true;
199 } 200 }
200 201
201 bool TransformTree::NeedsSourceToParentUpdate(TransformNode* node) { 202 bool TransformTree::NeedsSourceToParentUpdate(TransformNode* node) {
202 return (source_to_parent_updates_allowed() && 203 return (source_to_parent_updates_allowed() &&
203 node->parent_id != node->source_node_id); 204 node->parent_id != node->source_node_id);
204 } 205 }
205 206
(...skipping 1896 matching lines...) Expand 10 before | Expand all | Expand 10 after
2102 const EffectNode* effect_node = effect_tree.Node(effect_id); 2103 const EffectNode* effect_node = effect_tree.Node(effect_id);
2103 2104
2104 if (effect_node->surface_contents_scale.x() != 0.0 && 2105 if (effect_node->surface_contents_scale.x() != 0.0 &&
2105 effect_node->surface_contents_scale.y() != 0.0) 2106 effect_node->surface_contents_scale.y() != 0.0)
2106 screen_space_transform.Scale(1.0 / effect_node->surface_contents_scale.x(), 2107 screen_space_transform.Scale(1.0 / effect_node->surface_contents_scale.x(),
2107 1.0 / effect_node->surface_contents_scale.y()); 2108 1.0 / effect_node->surface_contents_scale.y());
2108 return screen_space_transform; 2109 return screen_space_transform;
2109 } 2110 }
2110 2111
2111 } // namespace cc 2112 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698