Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: PRESUBMIT_test.py

Issue 2895773002: (fix landed)Revert of Closure: remove older, original GYP compilation system (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « PRESUBMIT.py ('k') | components/chrome_apps/webstore_widget/app/compiled_resources.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT_test.py
diff --git a/PRESUBMIT_test.py b/PRESUBMIT_test.py
index 3fff4a2f2525b338a7e03926f78b7219401dc452..dd501604d402ae0efae9496e8492488f8608f51a 100755
--- a/PRESUBMIT_test.py
+++ b/PRESUBMIT_test.py
@@ -411,6 +411,20 @@
warnings = PRESUBMIT._CheckSingletonInHeaders(mock_input_api,
MockOutputApi())
self.assertEqual(0, len(warnings))
+
+
+class CheckNoDeprecatedCompiledResourcesGypTest(unittest.TestCase):
+ def testNoDeprecatedCompiledResourcsGyp(self):
+ mock_input_api = MockInputApi()
+ mock_input_api.files = [MockFile('some/js/compiled_resources.gyp', [])]
+ errors = PRESUBMIT._CheckNoDeprecatedCompiledResourcesGyp(mock_input_api,
+ MockOutputApi())
+ self.assertEquals(1, len(errors))
+
+ mock_input_api.files = [MockFile('some/js/compiled_resources2.gyp', [])]
+ errors = PRESUBMIT._CheckNoDeprecatedCompiledResourcesGyp(mock_input_api,
+ MockOutputApi())
+ self.assertEquals(0, len(errors))
class InvalidOSMacroNamesTest(unittest.TestCase):
« no previous file with comments | « PRESUBMIT.py ('k') | components/chrome_apps/webstore_widget/app/compiled_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698