Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: tools/ubsan/vptr_blacklist.txt

Issue 2895763002: Add UBSan vptr blacklist entries for swiftshader. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/ubsan/vptr_blacklist.txt
diff --git a/tools/ubsan/vptr_blacklist.txt b/tools/ubsan/vptr_blacklist.txt
index e838203923b25f28f2e1c5bc5a790786c44db43e..c84a65d0d00cc903af647f5e4f10a25e7f9545a3 100644
--- a/tools/ubsan/vptr_blacklist.txt
+++ b/tools/ubsan/vptr_blacklist.txt
@@ -100,6 +100,17 @@ src:*/third_party/libwebm/source/mkvmuxer.cpp
src:*third_party/swiftshader/third_party/LLVM*
#############################################################################
+# UBSan yields false positives in libEGL when objects created in libGLESv2
+# from classes derived from libEGL base classes are used within libEGL.
+# UBSan wrongly detects that the libGLESv2 classes are not derived from libEGL
+# classes because libEGL doesn't know about libGLESv2 classes.
+# See crbug.com/722349.
+type:*egl*Context*
+type:*egl*Surface*
+type:*gl*Object*
+type:*sw*FrameBuffer*
+
+#############################################################################
# UBSan seems to be emit false positives when virtual base classes are
# involved, see e.g. crbug.com/448102.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698