Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2895743002: Fix parser bug found while trying to reproduce a different bug (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix parser bug found while trying to reproduce a different bug R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/80fd95bb7020418b0989864d23884006c15adb18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -74 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 11 chunks +81 lines, -71 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-19 19:59:47 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-19 20:05:05 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-19 20:08:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80fd95bb7020418b0989864d23884006c15adb18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698