Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Unified Diff: ash/wm/ash_focus_rules.cc

Issue 2895713002: [mus+ash] Removes WmWindow from ash/wm/mru_window_tracker and overview mode (Closed)
Patch Set: Ash unittests compile (cleanup #include wm_window.h) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/ash_focus_rules.cc
diff --git a/ash/wm/ash_focus_rules.cc b/ash/wm/ash_focus_rules.cc
index 0930d707b34c3fc95013b7e16875a30c60e5ee97..2581f07b6a739d2d370660734967224c850e1e20 100644
--- a/ash/wm/ash_focus_rules.cc
+++ b/ash/wm/ash_focus_rules.cc
@@ -11,7 +11,6 @@
#include "ash/wm/focus_rules.h"
#include "ash/wm/mru_window_tracker.h"
#include "ash/wm/window_state.h"
-#include "ash/wm_window.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/window.h"
#include "ui/events/event.h"
@@ -42,7 +41,7 @@ AshFocusRules::~AshFocusRules() = default;
// AshFocusRules, ::wm::FocusRules:
bool AshFocusRules::IsToplevelWindow(aura::Window* window) const {
- return ash::IsToplevelWindow(WmWindow::Get(window));
+ return ash::IsToplevelWindow(window);
}
bool AshFocusRules::SupportsChildActivation(aura::Window* window) const {
@@ -51,7 +50,7 @@ bool AshFocusRules::SupportsChildActivation(aura::Window* window) const {
bool AshFocusRules::IsWindowConsideredVisibleForActivation(
aura::Window* window) const {
- return ash::IsWindowConsideredVisibleForActivation(WmWindow::Get(window));
+ return ash::IsWindowConsideredVisibleForActivation(window);
}
bool AshFocusRules::CanActivateWindow(aura::Window* window) const {
@@ -91,9 +90,8 @@ aura::Window* AshFocusRules::GetNextActivatableWindow(
// MRU windows is empty, then start from the container of the window that just
// lost focus |ignore|.
MruWindowTracker* mru = Shell::Get()->mru_window_tracker();
- std::vector<WmWindow*> windows = mru->BuildMruWindowList();
- aura::Window* starting_window =
- windows.empty() ? ignore : WmWindow::GetAuraWindow(windows[0]);
+ std::vector<aura::Window*> windows = mru->BuildMruWindowList();
msw 2017/05/23 22:50:24 ditto optional nit.
varkha 2017/05/24 15:29:14 Done.
+ aura::Window* starting_window = windows.empty() ? ignore : windows[0];
// Look for windows to focus in |starting_window|'s container. If none are
// found, we look in all the containers in front of |starting_window|'s

Powered by Google App Engine
This is Rietveld 408576698