third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc - Issue 2895673002: [scheduler] Add unthrottled-by-blockable task queue to fix touch latency regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc

Issue 2895673002: [scheduler] Add unthrottled-by-blockable task queue to fix touch latency regression. (Closed)

Patch Set: Address comments and disable a failing test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc ('k') | third_party/WebKit/Source/web/tests/scheduler/ThrottlingTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc

index ab04a9848d60a33cf36203c7c7210dc93acbb010..05a63eaf224ae102da021399d5e41385f5f567ed 100644

--- a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc

@@ -209,18 +209,20 @@ TEST_F(WebFrameSchedulerImplTest, SuspendAndResume) {

BLINK_FROM_HERE, WTF::Bind(&IncrementCounter, WTF::Unretained(&counter)));

web_frame_scheduler_->SuspendableTaskRunner()->PostTask(

BLINK_FROM_HERE, WTF::Bind(&IncrementCounter, WTF::Unretained(&counter)));

+ web_frame_scheduler_->UnthrottledButBlockableTaskRunner()->PostTask(

+ BLINK_FROM_HERE, WTF::Bind(&IncrementCounter, WTF::Unretained(&counter)));

web_frame_scheduler_->SetSuspended(true);

EXPECT_EQ(0, counter);

mock_task_runner_->RunUntilIdle();

- EXPECT_EQ(1, counter);

+ EXPECT_EQ(2, counter);

web_frame_scheduler_->SetSuspended(false);

- EXPECT_EQ(1, counter);

+ EXPECT_EQ(2, counter);

mock_task_runner_->RunUntilIdle();

- EXPECT_EQ(4, counter);

+ EXPECT_EQ(5, counter);

}

} // namespace scheduler