third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h - Issue 2895673002: [scheduler] Add unthrottled-by-blockable task queue to fix touch latency regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h

Issue 2895673002: [scheduler] Add unthrottled-by-blockable task queue to fix touch latency regression. (Closed)

Patch Set: Address comments and disable a failing test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc ('k') | third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h

diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h

index ae88331f376ff1e081abe3857a42049b36cc5d8b..f6f491c3f8e407906cb3c36c14e1b6ad62e7d474 100644

--- a/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h

+++ b/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h

@@ -47,6 +47,7 @@ class WebFrameSchedulerImpl : public WebFrameScheduler {

RefPtr<WebTaskRunner> TimerTaskRunner() override;

RefPtr<WebTaskRunner> SuspendableTaskRunner() override;

RefPtr<WebTaskRunner> UnthrottledTaskRunner() override;

+ RefPtr<WebTaskRunner> UnthrottledButBlockableTaskRunner() override;

WebViewScheduler* GetWebViewScheduler() override;

void DidStartLoading(unsigned long identifier) override;

void DidStopLoading(unsigned long identifier) override;

@@ -87,6 +88,7 @@ class WebFrameSchedulerImpl : public WebFrameScheduler {

scoped_refptr<TaskQueue> timer_task_queue_;

scoped_refptr<TaskQueue> unthrottled_task_queue_;

scoped_refptr<TaskQueue> suspendable_task_queue_;

+ scoped_refptr<TaskQueue> unthrottled_but_blockable_task_queue_;

std::unique_ptr<TaskQueue::QueueEnabledVoter> loading_queue_enabled_voter_;

std::unique_ptr<TaskQueue::QueueEnabledVoter> timer_queue_enabled_voter_;

std::unique_ptr<TaskQueue::QueueEnabledVoter>

@@ -95,6 +97,7 @@ class WebFrameSchedulerImpl : public WebFrameScheduler {

RefPtr<WebTaskRunnerImpl> timer_web_task_runner_;

RefPtr<WebTaskRunnerImpl> unthrottled_web_task_runner_;

RefPtr<WebTaskRunnerImpl> suspendable_web_task_runner_;

+ RefPtr<WebTaskRunnerImpl> unthrottled_but_blockable_web_task_runner_;

RendererSchedulerImpl* renderer_scheduler_; // NOT OWNED

WebViewSchedulerImpl* parent_web_view_scheduler_; // NOT OWNED

base::trace_event::BlameContext* blame_context_; // NOT OWNED