chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc - Issue 2895473005: [Payments] Have expiration date be on the same line in CC editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

Issue 2895473005: [Payments] Have expiration date be on the same line in CC editor (Closed)

Patch Set: Initial Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc ('K') | « chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc ('k') | chrome/browser/ui/views/payments/editor_view_controller.h » ('j') | chrome/browser/ui/views/payments/editor_view_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

index 471ace6096f838d904fd4d9831abcd16ad039ad2..4ff19b6849bed8a11dbc4a1cabcb77fdd95482de 100644

--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

@@ -190,10 +190,11 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest,

EXPECT_FALSE(IsEditorTextfieldInvalid(autofill::CREDIT_CARD_NAME_FULL));

EXPECT_FALSE(IsEditorTextfieldInvalid(autofill::CREDIT_CARD_NUMBER));

- // TODO(mathp): Both expiration fields should be marked as invalid when the

- // card is expired.

- EXPECT_FALSE(IsEditorComboboxInvalid(autofill::CREDIT_CARD_EXP_MONTH));

- EXPECT_FALSE(IsEditorComboboxInvalid(autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR));

+ EXPECT_TRUE(IsEditorComboboxInvalid(autofill::CREDIT_CARD_EXP_MONTH));

+ EXPECT_TRUE(IsEditorComboboxInvalid(autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR));

+ EXPECT_EQ(l10n_util::GetStringUTF16(

+ IDS_PAYMENTS_VALIDATION_INVALID_CREDIT_CARD_EXPIRED),

+ GetErrorLabelForType(autofill::CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR));

autofill::PersonalDataManager* personal_data_manager = GetDataManager();

EXPECT_EQ(0u, personal_data_manager->GetCreditCards().size());