Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h

Issue 2895473005: [Payments] Have expiration date be on the same line in CC editor (Closed)
Patch Set: addressed comments + rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_IDS_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_IDS_H_
6 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_IDS_H_ 6 #define CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_IDS_H_
7 7
8 #include "components/autofill/core/browser/field_types.h" 8 #include "components/autofill/core/browser/field_types.h"
9 9
10 // This defines an enumeration of IDs that can uniquely identify a view within 10 // This defines an enumeration of IDs that can uniquely identify a view within
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 58
59 // The following are views contained within the Payment Method Sheet. 59 // The following are views contained within the Payment Method Sheet.
60 CONTACT_INFO_SHEET_LIST_VIEW, 60 CONTACT_INFO_SHEET_LIST_VIEW,
61 PAYMENT_METHOD_SHEET_LIST_VIEW, 61 PAYMENT_METHOD_SHEET_LIST_VIEW,
62 SHIPPING_ADDRESS_SHEET_LIST_VIEW, 62 SHIPPING_ADDRESS_SHEET_LIST_VIEW,
63 63
64 // Used in selectable rows. Each row in a view reuses this ID, but the ID is 64 // Used in selectable rows. Each row in a view reuses this ID, but the ID is
65 // unique at the scope of the parent row. 65 // unique at the scope of the parent row.
66 CHECKMARK_VIEW, 66 CHECKMARK_VIEW,
67 67
68 // Used to label the error labels with an offset, which gets added to
69 // the Autofill type value they represent (for tests).
70 ERROR_LABEL_OFFSET,
71
72 // The CVC text field in the unmask sheet. 68 // The CVC text field in the unmask sheet.
73 CVC_PROMPT_TEXT_FIELD, 69 CVC_PROMPT_TEXT_FIELD,
74 CVC_ERROR_LABEL, 70 CVC_ERROR_LABEL,
75 71
76 // The following are the ids for the individual sheets. 72 // The following are the ids for the individual sheets.
77 CONTACT_INFO_EDITOR_SHEET, 73 CONTACT_INFO_EDITOR_SHEET,
78 CREDIT_CARD_EDITOR_SHEET, 74 CREDIT_CARD_EDITOR_SHEET,
79 CVC_UNMASK_SHEET, 75 CVC_UNMASK_SHEET,
80 SHIPPING_ADDRESS_EDITOR_SHEET, 76 SHIPPING_ADDRESS_EDITOR_SHEET,
81 77
82 // The combobox to choose a billing address to associate to a credit card. 78 // The combobox to choose a billing address to associate to a credit card.
83 CREDIT_CARD_BILLING_ADDRESS, 79 CREDIT_CARD_BILLING_ADDRESS,
80
81 // NOTE: Keep these values last.
82 // Used to offset the IDs of input fields, which gets added to the Autofill
83 // type value they represent.
84 INPUT_FIELD_TYPE_OFFSET,
85 // Used to label the error labels with an offset, which gets added to
86 // the Autofill type value they represent.
87 ERROR_LABEL_OFFSET = 2 * INPUT_FIELD_TYPE_OFFSET,
anthonyvd 2017/05/22 13:18:17 Can this be INPUT_FIELD_TYPE_OFFSET + autofill::MA
Mathieu 2017/05/22 16:30:40 Done.
84 }; 88 };
85 89
86 } // namespace payments 90 } // namespace payments
87 91
88 #endif // CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_IDS_H_ 92 #endif // CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_VIEW_IDS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698