Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

Issue 2895473005: [Payments] Have expiration date be on the same line in CC editor (Closed)
Patch Set: Initial Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 autofill::CREDIT_CARD_NUMBER); 183 autofill::CREDIT_CARD_NUMBER);
184 // The card is expired. 184 // The card is expired.
185 SetComboboxValue(base::ASCIIToUTF16("01"), autofill::CREDIT_CARD_EXP_MONTH); 185 SetComboboxValue(base::ASCIIToUTF16("01"), autofill::CREDIT_CARD_EXP_MONTH);
186 SetComboboxValue(base::ASCIIToUTF16("2017"), 186 SetComboboxValue(base::ASCIIToUTF16("2017"),
187 autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR); 187 autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR);
188 188
189 ClickOnDialogViewAndWait(DialogViewID::EDITOR_SAVE_BUTTON); 189 ClickOnDialogViewAndWait(DialogViewID::EDITOR_SAVE_BUTTON);
190 190
191 EXPECT_FALSE(IsEditorTextfieldInvalid(autofill::CREDIT_CARD_NAME_FULL)); 191 EXPECT_FALSE(IsEditorTextfieldInvalid(autofill::CREDIT_CARD_NAME_FULL));
192 EXPECT_FALSE(IsEditorTextfieldInvalid(autofill::CREDIT_CARD_NUMBER)); 192 EXPECT_FALSE(IsEditorTextfieldInvalid(autofill::CREDIT_CARD_NUMBER));
193 // TODO(mathp): Both expiration fields should be marked as invalid when the 193 EXPECT_TRUE(IsEditorComboboxInvalid(autofill::CREDIT_CARD_EXP_MONTH));
194 // card is expired. 194 EXPECT_TRUE(IsEditorComboboxInvalid(autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR));
195 EXPECT_FALSE(IsEditorComboboxInvalid(autofill::CREDIT_CARD_EXP_MONTH)); 195 EXPECT_EQ(l10n_util::GetStringUTF16(
196 EXPECT_FALSE(IsEditorComboboxInvalid(autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR)); 196 IDS_PAYMENTS_VALIDATION_INVALID_CREDIT_CARD_EXPIRED),
197 GetErrorLabelForType(autofill::CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR));
197 198
198 autofill::PersonalDataManager* personal_data_manager = GetDataManager(); 199 autofill::PersonalDataManager* personal_data_manager = GetDataManager();
199 EXPECT_EQ(0u, personal_data_manager->GetCreditCards().size()); 200 EXPECT_EQ(0u, personal_data_manager->GetCreditCards().size());
200 } 201 }
201 202
202 IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest, 203 IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest,
203 EnteringNothingInARequiredField) { 204 EnteringNothingInARequiredField) {
204 autofill::TestAutofillClock test_clock; 205 autofill::TestAutofillClock test_clock;
205 test_clock.SetNow(kJune2017); 206 test_clock.SetNow(kJune2017);
206 207
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 autofill::CREDIT_CARD_NAME_FULL); 597 autofill::CREDIT_CARD_NAME_FULL);
597 598
598 ValidatingTextfield* textfield = 599 ValidatingTextfield* textfield =
599 static_cast<ValidatingTextfield*>(dialog_view()->GetViewByID( 600 static_cast<ValidatingTextfield*>(dialog_view()->GetViewByID(
600 static_cast<int>(autofill::CREDIT_CARD_NAME_FULL))); 601 static_cast<int>(autofill::CREDIT_CARD_NAME_FULL)));
601 EXPECT_TRUE(textfield); 602 EXPECT_TRUE(textfield);
602 EXPECT_TRUE(textfield->invalid()); 603 EXPECT_TRUE(textfield->invalid());
603 } 604 }
604 605
605 } // namespace payments 606 } // namespace payments
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698