net/spdy/chromium/spdy_test_util_common.cc - Issue 2895263003: Revert CLs landed in HttpStreamFactoryImpl to track down a crasher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/chromium/spdy_test_util_common.cc

Issue 2895263003: Revert CLs landed in HttpStreamFactoryImpl to track down a crasher (Closed)

Patch Set: Revert "Fix SpdySessionKey for HTTP/2 alternative Jobs." Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/chromium/spdy_test_util_common.cc

diff --git a/net/spdy/chromium/spdy_test_util_common.cc b/net/spdy/chromium/spdy_test_util_common.cc

index edef81df10e51e94b3112544150efff0f78b1c2e..787ad80e498fcc98eb42b21da8cd34c92f0a3ddd 100644

--- a/net/spdy/chromium/spdy_test_util_common.cc

+++ b/net/spdy/chromium/spdy_test_util_common.cc

@@ -401,7 +401,6 @@ HttpNetworkSession::Params SpdySessionDependencies::CreateSessionParams(

params.http_auth_handler_factory =

session_deps->http_auth_handler_factory.get();

params.http_server_properties = session_deps->http_server_properties.get();

- params.client_socket_factory = session_deps->socket_factory.get();

params.enable_spdy_ping_based_connection_checking = session_deps->enable_ping;

params.enable_user_alternate_protocol_ports =

session_deps->enable_user_alternate_protocol_ports;