Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

Issue 2895253003: Split general DocumentMarkerController::AddMarker() method into spelling/grammar versions (Closed)
Patch Set: Split off InputMethodControllerTest changes, make other requested changes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
index 7e2b526ff7ea4a6685731c31760a880ce0f86b95..4ebb8ddfcc285223817869c1821cd69e5f974c20 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp
@@ -73,8 +73,8 @@ void DocumentMarkerControllerTest::MarkNodeContents(Node* node) {
// DocumentMarkerControllerTest::addMarker(), needs them.
GetDocument().UpdateStyleAndLayout();
auto range = EphemeralRange::RangeOfContents(*node);
- MarkerController().AddMarker(range.StartPosition(), range.EndPosition(),
- DocumentMarker::kSpelling);
+ MarkerController().AddSpellingMarker(range.StartPosition(),
+ range.EndPosition());
}
void DocumentMarkerControllerTest::MarkNodeContentsTextMatch(Node* node) {
@@ -315,9 +315,8 @@ TEST_F(DocumentMarkerControllerTest, RemoveSpellingMarkersUnderWords) {
// Add a spelling marker and a text match marker to "foo".
const EphemeralRange marker_range(Position(text, 0), Position(text, 3));
- MarkerController().AddMarker(marker_range.StartPosition(),
- marker_range.EndPosition(),
- DocumentMarker::kSpelling, "");
+ MarkerController().AddSpellingMarker(marker_range.StartPosition(),
+ marker_range.EndPosition());
MarkerController().AddTextMatchMarker(marker_range,
DocumentMarker::MatchStatus::kInactive);

Powered by Google App Engine
This is Rietveld 408576698