Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2895253003: Split general DocumentMarkerController::AddMarker() method into spelling/grammar versions (Closed)
Patch Set: Split off InputMethodControllerTest changes, make other requested changes Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
index 9158bdade0dbb7a800039726c17f3192f96b0118..6b1bd05b2ce3c86fe8d211a1e10fadb6132dbb42 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
@@ -54,10 +54,12 @@ class CORE_EXPORT DocumentMarkerController final
explicit DocumentMarkerController(Document&);
void Clear();
- void AddMarker(const Position& start,
- const Position& end,
- DocumentMarker::MarkerType,
- const String& description = g_empty_string);
+ void AddSpellingMarker(const Position& start,
+ const Position& end,
+ const String& description = g_empty_string);
+ void AddGrammarMarker(const Position& start,
+ const Position& end,
+ const String& description = g_empty_string);
void AddTextMatchMarker(const EphemeralRange&, DocumentMarker::MatchStatus);
void AddCompositionMarker(const Position& start,
const Position& end,
@@ -113,6 +115,10 @@ class CORE_EXPORT DocumentMarkerController final
private:
void AddMarker(Node*, DocumentMarker*);
+ void AddSpellCheckMarker(const Position& start,
+ const Position& end,
+ DocumentMarker::MarkerType,
+ const String& description = g_empty_string);
using MarkerLists = HeapVector<Member<DocumentMarkerList>,
DocumentMarker::kMarkerTypeIndexesCount>;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698